Improve new AND CHAIN tests

petere · petere · commit ef48a0573bf0 · 2019-09-09T10:31:35.000+02:00
Tweak the tests so that we're not just testing the default setting of
transaction_read_only.

Reported-by: fn ln &lt;emuser20140816@gmail.com&gt;
diff --git a/src/test/regress/expected/transactions.out b/src/test/regress/expected/transactions.out
@@ -940,15 +940,15 @@ ERROR:  RELEASE SAVEPOINT can only be used in transaction blocks
 -- but this is OK, because the BEGIN converts it to a regular xact
 SELECT 1\; BEGIN\; SAVEPOINT sp\; ROLLBACK TO SAVEPOINT sp\; COMMIT;
 -- Tests for AND CHAIN in implicit transaction blocks
-SET TRANSACTION READ WRITE\; COMMIT AND CHAIN;  -- error
+SET TRANSACTION READ ONLY\; COMMIT AND CHAIN;  -- error
 ERROR:  COMMIT AND CHAIN can only be used in transaction blocks
 SHOW transaction_read_only;
  transaction_read_only 
 -----------------------
  off
 (1 row)
 
-SET TRANSACTION READ WRITE\; ROLLBACK AND CHAIN;  -- error
+SET TRANSACTION READ ONLY\; ROLLBACK AND CHAIN;  -- error
 ERROR:  ROLLBACK AND CHAIN can only be used in transaction blocks
 SHOW transaction_read_only;
  transaction_read_only 
diff --git a/src/test/regress/sql/transactions.sql b/src/test/regress/sql/transactions.sql
@@ -542,10 +542,10 @@ SELECT 1\; BEGIN\; SAVEPOINT sp\; ROLLBACK TO SAVEPOINT sp\; COMMIT;
 
 -- Tests for AND CHAIN in implicit transaction blocks
 
-SET TRANSACTION READ WRITE\; COMMIT AND CHAIN;  -- error
+SET TRANSACTION READ ONLY\; COMMIT AND CHAIN;  -- error
 SHOW transaction_read_only;
 
-SET TRANSACTION READ WRITE\; ROLLBACK AND CHAIN;  -- error
+SET TRANSACTION READ ONLY\; ROLLBACK AND CHAIN;  -- error
 SHOW transaction_read_only;
 
 CREATE TABLE abc (a int);
