Rewrite for-loop, because this is not the Obfuscated C Code Contest.

bmomjian · bmomjian · commit ef581f0552b7 · 2003-01-11T05:01:03.000Z
Manfred Koizar
diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.50 2002/09/04 20:31:26 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.51 2003/01/11 05:01:03 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -409,8 +409,7 @@ PageIndexTupleDelete(Page page, OffsetNumber offnum)
 	unsigned	offset;
 	int			nbytes;
 	int			offidx;
-	int			nline,
-				i;
+	int			nline;
 
 	/*
 	 * As with PageRepairFragmentation, paranoia seems justified.
@@ -479,11 +478,12 @@ PageIndexTupleDelete(Page page, OffsetNumber offnum)
 	 */
 	if (!PageIsEmpty(page))
 	{
+		int i;
 		nline--;				/* there's one less than when we started */
-		for (i = nline; --i >= 0;)
+		for (i = 1; i <= nline; i++)
 		{
-			if (PageGetItemId(phdr, i + 1)->lp_off <= offset)
-				PageGetItemId(phdr, i + 1)->lp_off += size;
+			if (PageGetItemId(phdr, i)->lp_off <= offset)
+				PageGetItemId(phdr, i)->lp_off += size;
 		}
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.50 2002/09/04 20:31:26 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.51 2003/01/11 05:01:03 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -409,8 +409,7 @@ PageIndexTupleDelete(Page page, OffsetNumber offnum)`
`409`	`409`	`unsigned offset;`
`410`	`410`	`int nbytes;`
`411`	`411`	`int offidx;`
`412`		`- int nline,`
`413`		`- i;`
	`412`	`+ int nline;`
`414`	`413`
`415`	`414`	`/*`
`416`	`415`	`* As with PageRepairFragmentation, paranoia seems justified.`
`@@ -479,11 +478,12 @@ PageIndexTupleDelete(Page page, OffsetNumber offnum)`
`479`	`478`	`*/`
`480`	`479`	`if (!PageIsEmpty(page))`
`481`	`480`	`{`
	`481`	`+ int i;`
`482`	`482`	`nline--; /* there's one less than when we started */`
`483`		`- for (i = nline; --i >= 0;)`
	`483`	`+ for (i = 1; i <= nline; i++)`
`484`	`484`	`{`
`485`		`- if (PageGetItemId(phdr, i + 1)->lp_off <= offset)`
`486`		`- PageGetItemId(phdr, i + 1)->lp_off += size;`
	`485`	`+ if (PageGetItemId(phdr, i)->lp_off <= offset)`
	`486`	`+ PageGetItemId(phdr, i)->lp_off += size;`
`487`	`487`	`}`
`488`	`488`	`}`
`489`	`489`	`}`