Fix UPDATE of GENERATED ALWAYS identity columns

petere · petere · commit ef74e03ef65e · 2017-06-30T23:44:17.000-04:00
The bug would previously prevent the update of any column in a table
with identity columns, rather than just the actual identity column.

Reported-by: zam6ak@gmail.com
Bug: #14718
diff --git a/src/backend/rewrite/rewriteHandler.c b/src/backend/rewrite/rewriteHandler.c
@@ -827,7 +827,7 @@ rewriteTargetListIU(List *targetList,
 
 		if (commandType == CMD_UPDATE)
 		{
-			if (att_tup->attidentity == ATTRIBUTE_IDENTITY_ALWAYS && !apply_default)
+			if (att_tup->attidentity == ATTRIBUTE_IDENTITY_ALWAYS && new_tle && !apply_default)
 				ereport(ERROR,
 						(errcode(ERRCODE_GENERATED_ALWAYS),
 						 errmsg("column \"%s\" can only be updated to DEFAULT", NameStr(att_tup->attname)),

Original file line number	Diff line number	Diff line change
`@@ -827,7 +827,7 @@ rewriteTargetListIU(List *targetList,`
`827`	`827`
`828`	`828`	`if (commandType == CMD_UPDATE)`
`829`	`829`	`{`
`830`		`- if (att_tup->attidentity == ATTRIBUTE_IDENTITY_ALWAYS && !apply_default)`
	`830`	`+ if (att_tup->attidentity == ATTRIBUTE_IDENTITY_ALWAYS && new_tle && !apply_default)`
`831`	`831`	`ereport(ERROR,`
`832`	`832`	`(errcode(ERRCODE_GENERATED_ALWAYS),`
`833`	`833`	`errmsg("column \"%s\" can only be updated to DEFAULT", NameStr(att_tup->attname)),`