RemoveFunction didn't defend against too many args.

tglsfdc · tglsfdc · commit ef899c7f621f · 2000-01-12T05:25:09.000Z
diff --git a/src/backend/commands/remove.c b/src/backend/commands/remove.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.43 2000/01/10 17:14:32 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.44 2000/01/12 05:25:09 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -320,7 +320,9 @@ RemoveFunction(char *functionName,		/* function name to be removed */
 	char	   *typename;
 	int			i;
 
-
+	if (nargs > FUNC_MAX_ARGS)
+		elog(ERROR, "functions cannot have more than %d arguments",
+			 FUNC_MAX_ARGS);
 	MemSet(argList, 0, FUNC_MAX_ARGS * sizeof(Oid));
 	for (i = 0; i < nargs; i++)
 	{

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.43 2000/01/10 17:14:32 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.44 2000/01/12 05:25:09 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -320,7 +320,9 @@ RemoveFunction(char functionName, / function name to be removed */`
`320`	`320`	`char *typename;`
`321`	`321`	`int i;`
`322`	`322`
`323`		`-`
	`323`	`+ if (nargs > FUNC_MAX_ARGS)`
	`324`	`+ elog(ERROR, "functions cannot have more than %d arguments",`
	`325`	`+ FUNC_MAX_ARGS);`
`324`	`326`	`MemSet(argList, 0, FUNC_MAX_ARGS * sizeof(Oid));`
`325`	`327`	`for (i = 0; i < nargs; i++)`
`326`	`328`	`{`