pgbench: Avoid unnecessary measurement of connection delays.

MasaoFujii · MasaoFujii · commit efe2382d5ade · 2021-08-30T21:37:43.000+09:00
Commit 547f04e changed pgbench so that it used the measurement result of connection delays in its benchmark report only when -C/--connect option is specified. But previously those delays were unnecessarily measured even when that option is not specified. Which was a waste of cycles. This commit improves pgbench so that it avoids such unnecessary measurement. Back-patch to v14 where commit 547f04e first appeared. Author: Yugo Nagata Reviewed-by: Fabien COELHO, Asif Rehman, Fujii Masao Discussion: https://postgr.es/m/20210614151155.a393bc7d8fed183e38c9f52a@sraoss.co.jp
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -6622,6 +6622,7 @@ threadRun(void *arg)
 
 	thread_start = pg_time_now();
 	thread->started_time = thread_start;
+	thread->conn_duration = 0;
 	last_report = thread_start;
 	next_report = last_report + (int64) 1000000 * progress;
 
@@ -6645,14 +6646,6 @@ threadRun(void *arg)
 				goto done;
 			}
 		}
-
-		/* compute connection delay */
-		thread->conn_duration = pg_time_now() - thread->started_time;
-	}
-	else
-	{
-		/* no connection delay to record */
-		thread->conn_duration = 0;
 	}
 
 	/* GO */

Original file line number	Diff line number	Diff line change
`@@ -6622,6 +6622,7 @@ threadRun(void *arg)`
`6622`	`6622`
`6623`	`6623`	`thread_start = pg_time_now();`
`6624`	`6624`	`thread->started_time = thread_start;`
	`6625`	`+ thread->conn_duration = 0;`
`6625`	`6626`	`last_report = thread_start;`
`6626`	`6627`	`next_report = last_report + (int64) 1000000 * progress;`
`6627`	`6628`
`@@ -6645,14 +6646,6 @@ threadRun(void *arg)`
`6645`	`6646`	`goto done;`
`6646`	`6647`	`}`
`6647`	`6648`	`}`
`6648`		`-`
`6649`		`- /* compute connection delay */`
`6650`		`- thread->conn_duration = pg_time_now() - thread->started_time;`
`6651`		`- }`
`6652`		`- else`
`6653`		`- {`
`6654`		`- /* no connection delay to record */`
`6655`		`- thread->conn_duration = 0;`
`6656`	`6649`	`}`
`6657`	`6650`
`6658`	`6651`	`/* GO */`