Fix bug in clearing of virtual tuple slot.

anarazel · anarazel · commit f21776185648 · 2019-03-06T09:54:38.000-08:00
I broke/typoed this in 4da597e. Astonishingly this mostly doesn't cause breakage, except when trying to change the tuple descriptor of a slot (because TTS_FLAG_FIXED is assumed to be set). Author: Andres Freund
diff --git a/src/backend/executor/execTuples.c b/src/backend/executor/execTuples.c
@@ -114,7 +114,7 @@ tts_virtual_clear(TupleTableSlot *slot)
 		pfree(vslot->data);
 		vslot->data = NULL;
 
-		slot->tts_flags = ~TTS_FLAG_SHOULDFREE;
+		slot->tts_flags &= ~TTS_FLAG_SHOULDFREE;
 	}
 
 	slot->tts_nvalid = 0;

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ tts_virtual_clear(TupleTableSlot *slot)`
`114`	`114`	`pfree(vslot->data);`
`115`	`115`	`vslot->data = NULL;`
`116`	`116`
`117`		`- slot->tts_flags = ~TTS_FLAG_SHOULDFREE;`
	`117`	`+ slot->tts_flags &= ~TTS_FLAG_SHOULDFREE;`
`118`	`118`	`}`
`119`	`119`
`120`	`120`	`slot->tts_nvalid = 0;`