Update comment

petere · petere · commit f5744f1d1e35 · 2022-02-10T09:16:17.000+01:00
Update a comment that assumed that libc collations don't support
versioning.  Also improve an adjacent error message a bit.
diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
@@ -1609,11 +1609,11 @@ pg_newlocale_from_collation(Oid collid)
 			{
 				/*
 				 * This could happen when specifying a version in CREATE
-				 * COLLATION for a libc locale, or manually creating a mess in
-				 * the catalogs.
+				 * COLLATION but the provider does not support versioning, or
+				 * manually creating a mess in the catalogs.
 				 */
 				ereport(ERROR,
-						(errmsg("collation \"%s\" has no actual version, but a version was specified",
+						(errmsg("collation \"%s\" has no actual version, but a version was recorded",
 								NameStr(collform->collname))));
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -1609,11 +1609,11 @@ pg_newlocale_from_collation(Oid collid)`
`1609`	`1609`	`{`
`1610`	`1610`	`/*`
`1611`	`1611`	`* This could happen when specifying a version in CREATE`
`1612`		`- * COLLATION for a libc locale, or manually creating a mess in`
`1613`		`- * the catalogs.`
	`1612`	`+ * COLLATION but the provider does not support versioning, or`
	`1613`	`+ * manually creating a mess in the catalogs.`
`1614`	`1614`	`*/`
`1615`	`1615`	`ereport(ERROR,`
`1616`		`- (errmsg("collation \"%s\" has no actual version, but a version was specified",`
	`1616`	`+ (errmsg("collation \"%s\" has no actual version, but a version was recorded",`
`1617`	`1617`	`NameStr(collform->collname))));`
`1618`	`1618`	`}`
`1619`	`1619`