- Applied some bug fixing patches by Dave Cramer <dave@fastcrypt.com>.

Michael Meskes · Michael Meskes · commit f604b39c2f22 · 2003-09-20T09:10:09.000Z
- Added protecting defines to include files.
diff --git a/src/interfaces/ecpg/ChangeLog b/src/interfaces/ecpg/ChangeLog
@@ -1639,6 +1639,12 @@ Thu Sep 18 14:54:47 CEST 2003
 Fri Sep 19 08:33:39 CEST 2003
 
 	- Some code cleanup
+	
+Sat Sep 20 11:06:13 CEST 2003
+
+	- Applied some bug fixing patches by Dave Cramer <dave@fastcrypt.com>.
+	- Added protecting defines to include files.
+	- Renamed my own strndup() function because of a name clash.
 	- Set ecpg version to 3.0.0
 	- Set ecpg library to 4.0.0
 	- Set pgtypes library to 1.0.0
diff --git a/src/interfaces/ecpg/ecpglib/data.c b/src/interfaces/ecpg/ecpglib/data.c
@@ -1,4 +1,4 @@
-/* $Header: /cvsroot/pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.19 2003/09/19 14:06:21 meskes Exp $ */
+/* $Header: /cvsroot/pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.20 2003/09/20 09:10:09 meskes Exp $ */
 
 #define POSTGRES_ECPG_INTERNAL
 #include "postgres_fe.h"
@@ -393,10 +393,12 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 					/* did we get an error? */
 					if (errno != 0)
 					{
+						ECPGlog("ECPGget_data line %d: RESULT: %s errno %d\n", lineno, pval ? pval : "", errno);
+
 						if (INFORMIX_MODE(compat))
 						{
 							/* Informix wants its own NULL value here instead of an error */
-							ECPGset_informix_null(ECPGt_numeric, &nres);
+							ECPGset_informix_null(ECPGt_numeric, nres);
 						}
 						else
 						{
@@ -440,7 +442,7 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,
 						if (INFORMIX_MODE(compat))
 						{
 							/* Informix wants its own NULL value here instead of an error */
-							ECPGset_informix_null(ECPGt_interval, &ires);
+							ECPGset_informix_null(ECPGt_interval, ires);
 						}
 						else
 						{
diff --git a/src/interfaces/ecpg/include/datetime.h b/src/interfaces/ecpg/include/datetime.h
@@ -1,3 +1,6 @@
+#ifndef _ECPG_DATETIME_H
+#define _ECPG_DATETIME_H
+
 #include <pgtypes_timestamp.h>
 #include <pgtypes_interval.h>
 
@@ -11,3 +14,5 @@ extern int	dttoasc(dtime_t *, char *);
 extern int	dttofmtasc(dtime_t *, char *, int, char *);
 extern int	intoasc(intrvl_t *, char *);
 extern int	dtcvfmtasc(char *, char *, dtime_t *);
+
+#endif /* ndef _ECPG_DATETIME_H */
diff --git a/src/interfaces/ecpg/include/decimal.h b/src/interfaces/ecpg/include/decimal.h
@@ -1,3 +1,6 @@
+#ifndef _ECPG_DECIMAL_H
+#define _ECPG_DECIMAL_H
+
 #include <pgtypes_numeric.h>
 
 typedef decimal dec_t;
@@ -16,3 +19,5 @@ int			dectoasc(dec_t *, char *, int, int);
 int			dectodbl(dec_t *, double *);
 int			dectoint(dec_t *, int *);
 int			dectolong(dec_t *, long *);
+
+#endif /* ndef _ECPG_DECIMAL_H */
diff --git a/src/interfaces/ecpg/include/ecpg_informix.h b/src/interfaces/ecpg/include/ecpg_informix.h
@@ -1,3 +1,5 @@
+#ifndef _ECPG_INFORMIX_H
+#define _ECPG_INFORMIX_H
 /*
  * This file contains stuff needed to be as compatible to Informix as possible.
  */
@@ -32,3 +34,5 @@ extern void ldchar(char *, int, char *);
 
 extern void ECPG_informix_set_var(int, void *, int);
 extern void *ECPG_informix_get_var(int);
+
+#endif /* ndef _ECPG_INFORMIX_H */
diff --git a/src/interfaces/ecpg/include/ecpgerrno.h b/src/interfaces/ecpg/include/ecpgerrno.h
@@ -1,5 +1,5 @@
-#ifndef _ECPG_ERROR_H
-#define _ECPG_ERROR_H
+#ifndef _ECPG_ERRNO_H
+#define _ECPG_ERRNO_H
 
 #include <errno.h>
 
@@ -74,4 +74,4 @@
  /* WARNING:  BlankPortalAssignName: portal * already exists */
 #define ECPG_WARNING_PORTAL_EXISTS	   -605
 
-#endif   /* !_ECPG_ERROR_H */
+#endif   /* !_ECPG_ERRNO_H */
diff --git a/src/interfaces/ecpg/include/sql3types.h b/src/interfaces/ecpg/include/sql3types.h
@@ -1,8 +1,11 @@
+#ifndef _ECPG_SQL3TYPES_H
+#define _ECPG_SQL3TYPES_H
+
 /* SQL3 dynamic type codes
  *
  * Copyright (c) 2000, Christof Petig <christof.petig@wtal.de>
  *
- * $Header: /cvsroot/pgsql/src/interfaces/ecpg/include/sql3types.h,v 1.7 2001/10/28 06:26:11 momjian Exp $
+ * $Header: /cvsroot/pgsql/src/interfaces/ecpg/include/sql3types.h,v 1.8 2003/09/20 09:10:09 meskes Exp $
  */
 
 /* chapter 13.1 table 2: Codes used for SQL data types in Dynamic SQL */
@@ -41,3 +44,5 @@ enum
 	SQL3_DDT_ILLEGAL			/* not a datetime data type (not part of
 								 * standard) */
 };
+
+#endif /* !_ECPG_SQL3TYPES_H */
diff --git a/src/interfaces/ecpg/include/sqltypes.h b/src/interfaces/ecpg/include/sqltypes.h
@@ -1,3 +1,6 @@
+#ifndef ECPG_SQLTYPES_H
+#define ECPG_SQLTYPES_H
+
 #define CCHARTYPE	ECPGt_char
 #define CSHORTTYPE	ECPGt_short
 #define CINTTYPE	ECPGt_int
@@ -23,3 +26,5 @@
 #define CROWTYPE		123
 #define CLVCHARPTRTYPE	124
 #define CTYPEMAX	25
+
+#endif /* ndef ECPG_SQLTYPES_H */
diff --git a/src/interfaces/ecpg/pgtypeslib/numeric.c b/src/interfaces/ecpg/pgtypeslib/numeric.c
@@ -146,6 +146,7 @@ set_var_from_str(char *str, char **ptr, numeric *dest)
 	bool		have_dp = FALSE;
 	int			i = 0;
 
+	errno = 0;
 	*ptr = str;
 	while (*(*ptr))
 	{
@@ -1386,6 +1387,7 @@ PGTYPESnumeric_copy(numeric *src, numeric *dst)
 {
 	int			i;
 
+	if ( dst == NULL ) return -1;
 	zero_var(dst);
 
 	dst->weight = src->weight;
diff --git a/src/interfaces/ecpg/pgtypeslib/timestamp.c b/src/interfaces/ecpg/pgtypeslib/timestamp.c
@@ -573,7 +573,7 @@ dttofmtasc_replace(timestamp *ts, date dDate, int dow, struct tm * tm,
 					break;
 				case 'S':
 					replace_val.uint_val = tm->tm_sec;
-					replace_type = PGTYPES_TYPE_UINT;
+					replace_type = PGTYPES_TYPE_UINT_2_LZ;
 					break;
 				case 't':
 					replace_val.char_val = '\t';

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-/* $Header: /cvsroot/pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.19 2003/09/19 14:06:21 meskes Exp $ */`
	`1`	`+/* $Header: /cvsroot/pgsql/src/interfaces/ecpg/ecpglib/data.c,v 1.20 2003/09/20 09:10:09 meskes Exp $ */`
`2`	`2`
`3`	`3`	`#define POSTGRES_ECPG_INTERNAL`
`4`	`4`	`#include "postgres_fe.h"`
`@@ -393,10 +393,12 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`393`	`393`	`/* did we get an error? */`
`394`	`394`	`if (errno != 0)`
`395`	`395`	`{`
	`396`	`+ ECPGlog("ECPGget_data line %d: RESULT: %s errno %d\n", lineno, pval ? pval : "", errno);`
	`397`	`+`
`396`	`398`	`if (INFORMIX_MODE(compat))`
`397`	`399`	`{`
`398`	`400`	`/* Informix wants its own NULL value here instead of an error */`
`399`		`- ECPGset_informix_null(ECPGt_numeric, &nres);`
	`401`	`+ ECPGset_informix_null(ECPGt_numeric, nres);`
`400`	`402`	`}`
`401`	`403`	`else`
`402`	`404`	`{`
`@@ -440,7 +442,7 @@ ECPGget_data(const PGresult *results, int act_tuple, int act_field, int lineno,`
`440`	`442`	`if (INFORMIX_MODE(compat))`
`441`	`443`	`{`
`442`	`444`	`/* Informix wants its own NULL value here instead of an error */`
`443`		`- ECPGset_informix_null(ECPGt_interval, &ires);`
	`445`	`+ ECPGset_informix_null(ECPGt_interval, ires);`
`444`	`446`	`}`
`445`	`447`	`else`
`446`	`448`	`{`
Original file line number	Diff line number	Diff line change
`@@ -146,6 +146,7 @@ set_var_from_str(char str, char ptr, numeric dest)`
`146`	`146`	`bool have_dp = FALSE;`
`147`	`147`	`int i = 0;`
`148`	`148`
	`149`	`+ errno = 0;`
`149`	`150`	`*ptr = str;`
`150`	`151`	`while ((ptr))`
`151`	`152`	`{`
`@@ -1386,6 +1387,7 @@ PGTYPESnumeric_copy(numeric src, numeric dst)`
`1386`	`1387`	`{`
`1387`	`1388`	`int i;`
`1388`	`1389`
	`1390`	`+ if ( dst == NULL ) return -1;`
`1389`	`1391`	`zero_var(dst);`
`1390`	`1392`
`1391`	`1393`	`dst->weight = src->weight;`