Check that we have a working tar before trying to use it

adunstan · adunstan · commit f920f7e799c5 · 2021-12-08T10:24:07.000-05:00
Issue exposed by commit edc2332 and the buildfarm. Backpatch to release 14 where this usage started.
diff --git a/src/bin/pg_basebackup/t/010_pg_basebackup.pl b/src/bin/pg_basebackup/t/010_pg_basebackup.pl
@@ -268,7 +268,8 @@
 {
 	my $tar = $ENV{TAR};
 	skip "no tar program available", 1
-	  if (!defined $tar || $tar eq '');
+	  if (!defined $tar || $tar eq ''
+		  || system_log($tar, '--version') != 0);
 
 	my $node2 = PostgreSQL::Test::Cluster->new('replica');
 

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,8 @@`
`268`	`268`	`{`
`269`	`269`	`my $tar = $ENV{TAR};`
`270`	`270`	`skip "no tar program available", 1`
`271`		`- if (!defined $tar \|\| $tar eq '');`
	`271`	`+ if (!defined $tar \|\| $tar eq ''`
	`272`	`+ \|\| system_log($tar, '--version') != 0);`
`272`	`273`
`273`	`274`	`my $node2 = PostgreSQL::Test::Cluster->new('replica');`
`274`	`275`