Fix assorted inconsistent function declarations.

tglsfdc · tglsfdc · commit f97a0a2cc4bb · 2015-04-07T16:56:21.000-04:00
While gcc doesn't complain if you declare a function "static" and then
define it not-static, other compilers do; and in any case the code is
highly misleading this way.  Add the missing "static" keywords to a
couple of recent patches.  Per buildfarm member pademelon.
diff --git a/contrib/pg_upgrade/pg_upgrade.c b/contrib/pg_upgrade/pg_upgrade.c
@@ -293,7 +293,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32
diff --git a/src/bin/pg_resetxlog/pg_resetxlog.c b/src/bin/pg_resetxlog/pg_resetxlog.c
@@ -1191,7 +1191,7 @@ CreateRestrictedProcess(char *cmd, PROCESS_INFORMATION *processInfo, const char
 }
 #endif
 
-void
+static void
 get_restricted_token(const char *progname)
 {
 #ifdef WIN32

Original file line number	Diff line number	Diff line change
`@@ -293,7 +293,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`293`	`293`	`}`
`294`	`294`	`#endif`
`295`	`295`
`296`		`-void`
	`296`	`+static void`
`297`	`297`	`get_restricted_token(const char *progname)`
`298`	`298`	`{`
`299`	`299`	`#ifdef WIN32`
Original file line number	Diff line number	Diff line change
`@@ -1191,7 +1191,7 @@ CreateRestrictedProcess(char cmd, PROCESS_INFORMATION processInfo, const char`
`1191`	`1191`	`}`
`1192`	`1192`	`#endif`
`1193`	`1193`
`1194`		`-void`
	`1194`	`+static void`
`1195`	`1195`	`get_restricted_token(const char *progname)`
`1196`	`1196`	`{`
`1197`	`1197`	`#ifdef WIN32`