Fix BackgroundPsql's set_query_timer_restart() issue without argument.

MasahikoSawada · MasahikoSawada · commit f99dd98242d4 · 2023-11-30T10:14:17.000+09:00
The set_query_timer_restart() required an argument to define a value to query_timer_restart, but none of the existing callers passes an argument to this function. This changes the function to set a value without an argument. Backpatch through 16 where the background psql TAP functions were refactored by 664d757. Reviewed-by: Bharath Rupireddy, Tom Lane Discussion: https://postgr.es/m/CAD21AoA0B6VKe_5A9nZi8i5umwSN-zJJuPVNht9DaOZ9SJumMA@mail.gmail.com Backpatch-through: 16
diff --git a/src/test/perl/PostgreSQL/Test/BackgroundPsql.pm b/src/test/perl/PostgreSQL/Test/BackgroundPsql.pm
@@ -301,7 +301,7 @@ sub set_query_timer_restart
 {
 	my $self = shift;
 
-	$self->{query_timer_restart} = shift if @_;
+	$self->{query_timer_restart} = 1;
 	return $self->{query_timer_restart};
 }
 

Original file line number	Diff line number	Diff line change
`@@ -301,7 +301,7 @@ sub set_query_timer_restart`
`301`	`301`	`{`
`302`	`302`	`my $self = shift;`
`303`	`303`
`304`		`- $self->{query_timer_restart} = shift if @_;`
	`304`	`+ $self->{query_timer_restart} = 1;`
`305`	`305`	`return $self->{query_timer_restart};`
`306`	`306`	`}`
`307`	`307`