Add missing clean step to src/test/modules/brin/Makefile.

tglsfdc · tglsfdc · commit fa5e119dc71a · 2017-10-10T12:51:09.000-04:00
I noticed the tmp_check subdirectory wasn't getting cleaned up
after a check-world run.  Apparently pgxs.mk will only do this
for you if you've defined REGRESS.  The only other src/test/modules
Makefile that does not set that is snapshot_too_old, and it
does it like this.
diff --git a/src/test/modules/brin/Makefile b/src/test/modules/brin/Makefile
@@ -1,6 +1,9 @@
 # src/test/modules/brin/Makefile
 
-EXTRA_CLEAN = ./isolation_output
+# Note: because we don't tell the Makefile there are any regression tests,
+# we have to clean those result files explicitly
+EXTRA_CLEAN = $(pg_regress_clean_files) ./isolation_output
+
 EXTRA_INSTALL=contrib/pageinspect
 
 ISOLATIONCHECKS=summarization-and-inprogress-insertion
