MSVC: Avoid warning when testing a TAP suite without PROVE_FLAGS.

nmisch · nmisch · commit fb2641f8aa7f · 2020-06-07T16:27:17.000-07:00
Commit 7be5d8d surfaced the logic error, which had no functional implications, by adding "use warnings". The buildfarm always customizes PROVE_FLAGS, so the warning did not appear there. Back-patch to 9.5 (all supported versions).
diff --git a/src/tools/msvc/vcregress.pl b/src/tools/msvc/vcregress.pl
@@ -196,7 +196,7 @@ sub tap_check
 	  unless $config->{tap_tests};
 
 	my @flags;
-	foreach my $arg (0 .. scalar(@_))
+	foreach my $arg (0 .. scalar(@_) - 1)
 	{
 		next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;
 		@flags = split(/\s+/, $1);

Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,7 @@ sub tap_check`
`196`	`196`	`unless $config->{tap_tests};`
`197`	`197`
`198`	`198`	`my @flags;`
`199`		`- foreach my $arg (0 .. scalar(@_))`
	`199`	`+ foreach my $arg (0 .. scalar(@_) - 1)`
`200`	`200`	`{`
`201`	`201`	`next unless $_[$arg] =~ /^PROVE_FLAGS=(.*)/;`
`202`	`202`	`@flags = split(/\s+/, $1);`