Fix 007_sync_rep.pl to notice failures in ALTER SYSTEM SET.

tglsfdc · tglsfdc · commit fb57f40eec50 · 2019-08-26T17:02:52.000-04:00
If a test case tried to set an invalid value of synchronous_standby_names,
the test script didn't detect that, which seems like a bad idea.
Noticed while testing a proposed patch that broke some of these
test cases.
diff --git a/src/test/recovery/t/007_sync_rep.pl b/src/test/recovery/t/007_sync_rep.pl
@@ -18,7 +18,7 @@ sub test_sync_state
 
 	if (defined($setting))
 	{
-		$self->psql('postgres',
+		$self->safe_psql('postgres',
 			"ALTER SYSTEM SET synchronous_standby_names = '$setting';");
 		$self->reload;
 	}

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ sub test_sync_state`
`18`	`18`
`19`	`19`	`if (defined($setting))`
`20`	`20`	`{`
`21`		`- $self->psql('postgres',`
	`21`	`+ $self->safe_psql('postgres',`
`22`	`22`	`"ALTER SYSTEM SET synchronous_standby_names = '$setting';");`
`23`	`23`	`$self->reload;`
`24`	`24`	`}`