Fix minor memory leaks in pg_dump.

tglsfdc · tglsfdc · commit fcd77a687301 · 2025-02-12T15:46:31.000-05:00
Coverity reported the two oversights in getPublicationTables.
Valgrind found the one in determineNotNullFlags.

The mistakes in getPublicationTables seem too minor to be worth
back-patching.  determineNotNullFlags could be run enough times
to matter, but that code is new in v18.  So, no back-patch.
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -4682,6 +4682,8 @@ getPublicationTables(Archive *fout, TableInfo tblinfo[], int numTables)
 				appendPQExpBufferStr(attribs, fmtId(attnames[k]));
 			}
 			pubrinfo[j].pubrattrs = attribs->data;
+			free(attribs);		/* but not attribs->data */
+			free(attnames);
 		}
 		else
 			pubrinfo[j].pubrattrs = NULL;
@@ -9424,6 +9426,7 @@ determineNotNullFlags(Archive *fout, PGresult *res, int r,
 					tbinfo->notnull_constrs[j] =
 						pstrdup(PQgetvalue(res, r, i_notnull_name));
 				}
+				free(default_name);
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -4682,6 +4682,8 @@ getPublicationTables(Archive *fout, TableInfo tblinfo[], int numTables)`
`4682`	`4682`	`appendPQExpBufferStr(attribs, fmtId(attnames[k]));`
`4683`	`4683`	`}`
`4684`	`4684`	`pubrinfo[j].pubrattrs = attribs->data;`
	`4685`	`+ free(attribs); /* but not attribs->data */`
	`4686`	`+ free(attnames);`
`4685`	`4687`	`}`
`4686`	`4688`	`else`
`4687`	`4689`	`pubrinfo[j].pubrattrs = NULL;`
`@@ -9424,6 +9426,7 @@ determineNotNullFlags(Archive fout, PGresult res, int r,`
`9424`	`9426`	`tbinfo->notnull_constrs[j] =`
`9425`	`9427`	`pstrdup(PQgetvalue(res, r, i_notnull_name));`
`9426`	`9428`	`}`
	`9429`	`+ free(default_name);`
`9427`	`9430`	`}`
`9428`	`9431`	`}`
`9429`	`9432`	`}`