Fix portability issue in tests from commit ce773f2.

tglsfdc · tglsfdc · commit fd549145d5d9 · 2021-09-03T10:01:02.000-04:00
Modern POSIX seems to require strtod() to accept "-NaN", but there's
nothing about NaN in SUSv2, and some of our oldest buildfarm members
don't like it.  Let's try writing it as -'NaN' instead; that seems
to produce the same result, at least on Intel hardware.

Per buildfarm.
diff --git a/src/test/regress/expected/hash_func.out b/src/test/regress/expected/hash_func.out
@@ -348,7 +348,7 @@ SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;
  t
 (1 row)
 
-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;
+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;
  t 
 ---
  t
@@ -360,7 +360,7 @@ SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;
  t
 (1 row)
 
-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;
+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;
  t 
 ---
  t
diff --git a/src/test/regress/sql/hash_func.sql b/src/test/regress/sql/hash_func.sql
@@ -258,7 +258,7 @@ DROP TYPE hash_test_t2;
 -- Check special cases for specific data types
 --
 SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;
-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;
+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;
 SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;
-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;
+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;
 SELECT hashfloat4('NaN'::float4) = hashfloat8('NaN'::float8) AS t;

Original file line number	Diff line number	Diff line change
`@@ -348,7 +348,7 @@ SELECT hashfloat4('0'::float4) = hashfloat4('-0'::float4) AS t;`
`348`	`348`	`t`
`349`	`349`	`(1 row)`
`350`	`350`
`351`		`-SELECT hashfloat4('NaN'::float4) = hashfloat4('-NaN'::float4) AS t;`
	`351`	`+SELECT hashfloat4('NaN'::float4) = hashfloat4(-'NaN'::float4) AS t;`
`352`	`352`	`t`
`353`	`353`	`---`
`354`	`354`	`t`
`@@ -360,7 +360,7 @@ SELECT hashfloat8('0'::float8) = hashfloat8('-0'::float8) AS t;`
`360`	`360`	`t`
`361`	`361`	`(1 row)`
`362`	`362`
`363`		`-SELECT hashfloat8('NaN'::float8) = hashfloat8('-NaN'::float8) AS t;`
	`363`	`+SELECT hashfloat8('NaN'::float8) = hashfloat8(-'NaN'::float8) AS t;`
`364`	`364`	`t`
`365`	`365`	`---`
`366`	`366`	`t`