Skip to content

Commit fecc04f

Browse files
committed
This patch fixes in intermittent failure in the regression tests:
there was a race condition between the "alter_table" and "rules" regression tests. Depending on scheduling, sometimes an ALTER TABLE command would operate on a relation created by the "rules" tests, leading to unexpected results. Neil Conway
1 parent ce3d087 commit fecc04f

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/test/regress/expected/alter_table.out

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -615,10 +615,10 @@ ERROR: ALTER TABLE: relation "pg_class" is a system catalog
615615
alter table pg_class alter relname set not null;
616616
ERROR: ALTER TABLE: relation "pg_class" is a system catalog
617617
-- try altering non-existent table, should fail
618-
alter table foo alter column bar set not null;
619-
ERROR: Relation "foo" does not exist
620-
alter table foo alter column bar drop not null;
621-
ERROR: Relation "foo" does not exist
618+
alter table non_existent alter column bar set not null;
619+
ERROR: Relation "non_existent" does not exist
620+
alter table non_existent alter column bar drop not null;
621+
ERROR: Relation "non_existent" does not exist
622622
-- test setting columns to null and not null and vice versa
623623
-- test checking for null values and primary key
624624
create table atacc1 (test int not null);

src/test/regress/sql/alter_table.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -478,8 +478,8 @@ alter table pg_class alter column relname drop not null;
478478
alter table pg_class alter relname set not null;
479479

480480
-- try altering non-existent table, should fail
481-
alter table foo alter column bar set not null;
482-
alter table foo alter column bar drop not null;
481+
alter table non_existent alter column bar set not null;
482+
alter table non_existent alter column bar drop not null;
483483

484484
-- test setting columns to null and not null and vice versa
485485
-- test checking for null values and primary key

0 commit comments

Comments
 (0)
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy