Fix up JOIN .. USING with domains

bmomjian · bmomjian · commit ff4c69e02183 · 2003-06-25T04:32:03.000Z
The attached fixes select_common_type() to support the below case:

create table t1( c1 int);
create domain dom_c1 int;
create table t2(c1 dom_c1);
select * from t1 join t2 using( c1 );

I didn't see a need for maintaining the domain as the preferred type. A
simple getBaseType() call on all elements of the list seems to be
enough.

--
Rod Taylor &lt;rbt@rbt.ca&gt;
diff --git a/src/backend/parser/parse_coerce.c b/src/backend/parser/parse_coerce.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.98 2003/06/24 23:14:45 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.99 2003/06/25 04:32:03 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -599,11 +599,11 @@ select_common_type(List *typeids, const char *context)
 	List	   *l;
 
 	Assert(typeids != NIL);
-	ptype = lfirsto(typeids);
+	ptype = getBaseType(lfirsto(typeids));
 	pcategory = TypeCategory(ptype);
 	foreach(l, lnext(typeids))
 	{
-		Oid			ntype = lfirsto(l);
+		Oid			ntype = getBaseType(lfirsto(l));
 
 		/* move on to next one if no new information... */
 		if ((ntype != InvalidOid) && (ntype != UNKNOWNOID) && (ntype != ptype))

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.98 2003/06/24 23:14:45 momjian Exp $`
	`11`	`+ * $Header: /cvsroot/pgsql/src/backend/parser/parse_coerce.c,v 2.99 2003/06/25 04:32:03 momjian Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -599,11 +599,11 @@ select_common_type(List typeids, const char context)`
`599`	`599`	`List *l;`
`600`	`600`
`601`	`601`	`Assert(typeids != NIL);`
`602`		`- ptype = lfirsto(typeids);`
	`602`	`+ ptype = getBaseType(lfirsto(typeids));`
`603`	`603`	`pcategory = TypeCategory(ptype);`
`604`	`604`	`foreach(l, lnext(typeids))`
`605`	`605`	`{`
`606`		`- Oid ntype = lfirsto(l);`
	`606`	`+ Oid ntype = getBaseType(lfirsto(l));`
`607`	`607`
`608`	`608`	`/* move on to next one if no new information... */`
`609`	`609`	`if ((ntype != InvalidOid) && (ntype != UNKNOWNOID) && (ntype != ptype))`