Fix ancient compiler warnings and typos in !HAVE_SYMLINK code

petere · petere · commit ffcd98c7fcfb · 2018-12-22T07:26:45.000+01:00
This has never been correct since this code was introduced.
diff --git a/src/bin/initdb/initdb.c b/src/bin/initdb/initdb.c
@@ -3206,7 +3206,7 @@ create_xlog_or_symlink(void)
 			exit_nicely();
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit_nicely();
 #endif
 	}
diff --git a/src/bin/pg_basebackup/pg_basebackup.c b/src/bin/pg_basebackup/pg_basebackup.c
@@ -2280,7 +2280,7 @@ main(int argc, char **argv)
 			exit(1);
 		}
 #else
-		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));
+		fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);
 		exit(1);
 #endif
 		free(linkloc);

Original file line number	Diff line number	Diff line change
`@@ -3206,7 +3206,7 @@ create_xlog_or_symlink(void)`
`3206`	`3206`	`exit_nicely();`
`3207`	`3207`	`}`
`3208`	`3208`	`#else`
`3209`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform"));`
	`3209`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`3210`	`3210`	`exit_nicely();`
`3211`	`3211`	`#endif`
`3212`	`3212`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2280,7 +2280,7 @@ main(int argc, char **argv)`
`2280`	`2280`	`exit(1);`
`2281`	`2281`	`}`
`2282`	`2282`	`#else`
`2283`		`- fprintf(stderr, _("%s: symlinks are not supported on this platform\n"));`
	`2283`	`+ fprintf(stderr, _("%s: symlinks are not supported on this platform\n"), progname);`
`2284`	`2284`	`exit(1);`
`2285`	`2285`	`#endif`
`2286`	`2286`	`free(linkloc);`