Be less wishy-washy in the documentation and comments about whether a

tglsfdc · tglsfdc · commit 0153c4c4663f · 2008-01-15T22:18:20.000Z
ParameterStatus message can be sent during COPY OUT: it's definitely
possible, since COPY from a SELECT subquery can trigger any user-defined
function.
diff --git a/doc/src/sgml/protocol.sgml b/doc/src/sgml/protocol.sgml
@@ -1,4 +1,4 @@
-<!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.71 2008/01/14 18:46:17 tgl Exp $ -->
+<!-- $PostgreSQL: pgsql/doc/src/sgml/protocol.sgml,v 1.72 2008/01/15 22:18:20 tgl Exp $ -->
 
 <chapter id="protocol">
  <title>Frontend/Backend Protocol</title>
@@ -1044,10 +1044,10 @@
    </para>
 
    <para>
-    It is possible for NoticeResponse messages to be interspersed between
-    CopyData messages; frontends must handle this case, and should be
-    prepared for other asynchronous message types as well (see <xref
-    linkend="protocol-async">).  Otherwise, any message type other than
+    It is possible for NoticeResponse and ParameterStatus messages to be
+    interspersed between CopyData messages; frontends must handle these cases,
+    and should be prepared for other asynchronous message types as well (see
+    <xref linkend="protocol-async">).  Otherwise, any message type other than
     CopyData or CopyDone may be treated as terminating copy-out mode.
    </para>
 
diff --git a/src/interfaces/libpq/fe-protocol3.c b/src/interfaces/libpq/fe-protocol3.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.32 2008/01/14 18:46:17 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.33 2008/01/15 22:18:20 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn)
 		/*
 		 * If it's a legitimate async message type, process it.  (NOTIFY
 		 * messages are not currently possible here, but we handle them for
-		 * completeness.  NOTICE is definitely possible, and ParameterStatus
-		 * could probably be made to happen.)  Otherwise, if it's anything
-		 * except Copy Data, report end-of-copy.
+		 * completeness.)  Otherwise, if it's anything except Copy Data,
+		 * report end-of-copy.
 		 */
 		switch (id)
 		{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.32 2008/01/14 18:46:17 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/interfaces/libpq/fe-protocol3.c,v 1.33 2008/01/15 22:18:20 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -1310,9 +1310,8 @@ getCopyDataMessage(PGconn *conn)`
`1310`	`1310`	`/*`
`1311`	`1311`	`* If it's a legitimate async message type, process it. (NOTIFY`
`1312`	`1312`	`* messages are not currently possible here, but we handle them for`
`1313`		`- * completeness. NOTICE is definitely possible, and ParameterStatus`
`1314`		`- * could probably be made to happen.) Otherwise, if it's anything`
`1315`		`- * except Copy Data, report end-of-copy.`
	`1313`	`+ * completeness.) Otherwise, if it's anything except Copy Data,`
	`1314`	`+ * report end-of-copy.`
`1316`	`1315`	`*/`
`1317`	`1316`	`switch (id)`
`1318`	`1317`	`{`