further refactoring and improvements (new function is_pathman_related_table_rename(), remove redundant function get_rel_parent()

funbringer · funbringer · commit 01ef629726c1 · 2016-11-23T17:38:23.000+03:00
diff --git a/expected/pathman_utility_stmt_hooking.out b/expected/pathman_utility_stmt_hooking.out
@@ -220,16 +220,16 @@ Inherits: rename.test
 CREATE OR REPLACE FUNCTION add_constraint(rel regclass, att text)
 RETURNS VOID AS $$
 declare
-    constraint_name text := build_check_constraint_name(rel, 'a');
+	constraint_name text := build_check_constraint_name(rel, 'a');
 BEGIN
-    EXECUTE format('ALTER TABLE %s ADD CONSTRAINT %s CHECK (a < 100);',
-                   rel, constraint_name);
+	EXECUTE format('ALTER TABLE %s ADD CONSTRAINT %s CHECK (a < 100);',
+				   rel, constraint_name);
 END
 $$
 LANGUAGE plpgsql;
 /*
- * Check that it doesn't affect regular inherited tables that aren't managed
- * by pg_pathman
+ * Check that it doesn't affect regular inherited
+ * tables that aren't managed by pg_pathman
  */
 CREATE TABLE rename.test_inh (LIKE rename.test INCLUDING ALL);
 CREATE TABLE rename.test_inh_1 (LIKE rename.test INCLUDING ALL);
diff --git a/sql/pathman_utility_stmt_hooking.sql b/sql/pathman_utility_stmt_hooking.sql
@@ -93,6 +93,7 @@ SELECT * FROM copy_stmt_hooking.test ORDER BY val;
 
 DROP SCHEMA copy_stmt_hooking CASCADE;
 
+
 /*
  * Test auto check constraint renaming
  */
@@ -108,17 +109,17 @@ ALTER TABLE rename.test_0 RENAME TO test_one;
 CREATE OR REPLACE FUNCTION add_constraint(rel regclass, att text)
 RETURNS VOID AS $$
 declare
-    constraint_name text := build_check_constraint_name(rel, 'a');
+	constraint_name text := build_check_constraint_name(rel, 'a');
 BEGIN
-    EXECUTE format('ALTER TABLE %s ADD CONSTRAINT %s CHECK (a < 100);',
-                   rel, constraint_name);
+	EXECUTE format('ALTER TABLE %s ADD CONSTRAINT %s CHECK (a < 100);',
+				   rel, constraint_name);
 END
 $$
 LANGUAGE plpgsql;
 
 /*
- * Check that it doesn't affect regular inherited tables that aren't managed
- * by pg_pathman
+ * Check that it doesn't affect regular inherited
+ * tables that aren't managed by pg_pathman
  */
 CREATE TABLE rename.test_inh (LIKE rename.test INCLUDING ALL);
 CREATE TABLE rename.test_inh_1 (LIKE rename.test INCLUDING ALL);
diff --git a/src/hooks.c b/src/hooks.c
@@ -35,10 +35,6 @@ shmem_startup_hook_type			shmem_startup_hook_next = NULL;
 ProcessUtility_hook_type		process_utility_hook_next = NULL;
 
 
-#define is_table_rename_statement(s) \
-			IsA((s), RenameStmt) && ((RenameStmt *)(s))->renameType == OBJECT_TABLE
-
-
 /* Take care of joins */
 void
 pathman_join_pathlist_hook(PlannerInfo *root,
@@ -631,9 +627,12 @@ pathman_process_utility_hook(Node *parsetree,
 							 DestReceiver *dest,
 							 char *completionTag)
 {
-	/* Override standard COPY statement if needed */
 	if (IsPathmanReady())
 	{
+		Oid			partition_relid;
+		AttrNumber	partitioned_col;
+
+		/* Override standard COPY statement if needed */
 		if (is_pathman_related_copy(parsetree))
 		{
 			uint64	processed;
@@ -647,14 +646,13 @@ pathman_process_utility_hook(Node *parsetree,
 			return; /* don't call standard_ProcessUtility() or hooks */
 		}
 
-		if (is_table_rename_statement(parsetree))
-		{
-			/*
-			 * Rename check constraint of a table if it is a partition managed
-			 * by pg_pathman
-			 */
-			PathmanRenameConstraint((RenameStmt *) parsetree);
-		}
+		/* Override standard RENAME statement if needed */
+		if (is_pathman_related_table_rename(parsetree,
+											&partition_relid,
+											&partitioned_col))
+			PathmanRenameConstraint(partition_relid,
+									partitioned_col,
+									(const RenameStmt *) parsetree);
 	}
 
 	/* Call hooks set by other extensions if needed */
diff --git a/src/init.c b/src/init.c
@@ -602,7 +602,7 @@ build_check_constraint_name_relid_internal(Oid relid, AttrNumber attno)
 }
 
 char *
-build_check_constraint_name_relname_internal(char *relname, AttrNumber attno)
+build_check_constraint_name_relname_internal(const char *relname, AttrNumber attno)
 {
 	return psprintf("pathman_%s_%u_check", relname, attno);
 }
diff --git a/src/init.h b/src/init.h
@@ -126,7 +126,7 @@ find_children_status find_inheritance_children_array(Oid parentrelId,
 char *build_check_constraint_name_relid_internal(Oid relid,
 												 AttrNumber attno);
 
-char *build_check_constraint_name_relname_internal(char *relname,
+char *build_check_constraint_name_relname_internal(const char *relname,
 												   AttrNumber attno);
 
 bool pathman_config_contains_relation(Oid relid,
diff --git a/src/utility_stmt_hooking.c b/src/utility_stmt_hooking.c
@@ -11,27 +11,23 @@
  * ------------------------------------------------------------------------
  */
 
-#include "utility_stmt_hooking.h"
 #include "init.h"
+#include "utility_stmt_hooking.h"
 #include "partition_filter.h"
 #include "relation_info.h"
 
 #include "access/htup_details.h"
 #include "access/sysattr.h"
 #include "access/xact.h"
 #include "catalog/namespace.h"
-#include "catalog/pg_attribute.h"
 #include "commands/copy.h"
 #include "commands/trigger.h"
 #include "commands/tablecmds.h"
-#include "executor/executor.h"
 #include "foreign/fdwapi.h"
 #include "miscadmin.h"
-#include "nodes/makefuncs.h"
 #include "utils/builtins.h"
 #include "utils/lsyscache.h"
 #include "utils/memutils.h"
-#include "utils/rel.h"
 #include "utils/rls.h"
 
 #include "libpq/libpq.h"
@@ -74,7 +70,7 @@ bool
 is_pathman_related_copy(Node *parsetree)
 {
 	CopyStmt   *copy_stmt = (CopyStmt *) parsetree;
-	Oid			partitioned_table;
+	Oid			parent_relid;
 
 	Assert(IsPathmanReady());
 
@@ -93,14 +89,14 @@ is_pathman_related_copy(Node *parsetree)
 		return false;
 
 	/* Get partition's Oid while locking it */
-	partitioned_table = RangeVarGetRelid(copy_stmt->relation,
-										 (copy_stmt->is_from ?
-											  RowExclusiveLock :
-											  AccessShareLock),
-										 false);
+	parent_relid = RangeVarGetRelid(copy_stmt->relation,
+									(copy_stmt->is_from ?
+										RowExclusiveLock :
+										AccessShareLock),
+									false);
 
 	/* Check that relation is partitioned */
-	if (get_pathman_relation_info(partitioned_table))
+	if (get_pathman_relation_info(parent_relid))
 	{
 		ListCell *lc;
 
@@ -121,7 +117,7 @@ is_pathman_related_copy(Node *parsetree)
 			elog(ERROR, "COPY is not supported for partitioned tables on Windows");
 		#else
 			elog(DEBUG1, "Overriding default behavior for COPY [%u]",
-				 partitioned_table);
+				 parent_relid);
 		#endif
 
 		return true;
@@ -130,6 +126,57 @@ is_pathman_related_copy(Node *parsetree)
 	return false;
 }
 
+/*
+ * Is pg_pathman supposed to handle this table rename stmt?
+ */
+bool
+is_pathman_related_table_rename(Node *parsetree,
+								Oid *partition_relid_out,			/* ret value */
+								AttrNumber *partitioned_col_out)	/* ret value */
+{
+	RenameStmt			   *rename_stmt = (RenameStmt *) parsetree;
+	Oid						partition_relid,
+							parent_relid;
+	const PartRelationInfo *prel;
+	PartParentSearch		parent_search;
+
+	Assert(IsPathmanReady());
+
+	/* Set default values */
+	if (partition_relid_out) *partition_relid_out = InvalidOid;
+	if (partitioned_col_out) *partitioned_col_out = InvalidAttrNumber;
+
+	if (!IsA(parsetree, RenameStmt))
+		return false;
+
+	/* Are we going to rename some table? */
+	if (rename_stmt->renameType != OBJECT_TABLE)
+		return false;
+
+	/* Assume it's a partition, fetch its Oid */
+	partition_relid = RangeVarGetRelid(rename_stmt->relation,
+									   AccessShareLock,
+									   false);
+
+	/* Try fetching parent of this table */
+	parent_relid = get_parent_of_partition(partition_relid, &parent_search);
+	if (parent_search != PPS_ENTRY_PART_PARENT)
+		return false;
+
+	/* Is parent partitioned? */
+	if ((prel = get_pathman_relation_info(parent_relid)) != NULL)
+	{
+		/* Return 'partition_relid' and 'prel->attnum' */
+		if (partition_relid_out) *partition_relid_out = partition_relid;
+		if (partitioned_col_out) *partitioned_col_out = prel->attnum;
+
+		return true;
+	}
+
+	return false;
+}
+
+
 /*
  * CopyGetAttnums - build an integer list of attnums to be copied
  *
@@ -238,6 +285,7 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 						   "psql's \\copy command also works for anyone.")));
 	}
 
+	/* Check that we have a relation */
 	if (stmt->relation)
 	{
 		TupleDesc		tupDesc;
@@ -363,13 +411,9 @@ PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed)
 			rel = NULL;
 		}
 	}
-	else
-	{
-		Assert(stmt->query);
 
-		query = stmt->query;
-		rel = NULL;
-	}
+	/* This should never happen (see is_pathman_related_copy()) */
+	else elog(ERROR, "error in function \"%s\"", CppAsString(PathmanDoCopy));
 
 	/* COPY ... FROM ... */
 	if (is_from)
@@ -626,45 +670,35 @@ prepare_rri_fdw_for_copy(EState *estate,
 }
 
 /*
- * Rename check constraint of table if it's a partition
+ * Rename RANGE\HASH check constraint of a partition on table rename event.
  */
 void
-PathmanRenameConstraint(const RenameStmt *stmt)
+PathmanRenameConstraint(Oid partition_relid,				/* cached partition Oid */
+						AttrNumber partitioned_col,			/* partitioned column */
+						const RenameStmt *part_rename_stmt)	/* partition rename stmt */
 {
-	Oid						partition_relid,
-							parent_relid;
-	char				   *old_constraint_name,
-						   *new_constraint_name;
-	RenameStmt			   *rename_stmt;
-	const PartRelationInfo *prel;
-
-	partition_relid = RangeVarGetRelid(stmt->relation, AccessShareLock, false);
-	parent_relid = get_rel_parent(partition_relid);
-
-	/* Skip if there's no parent */
-	if (!OidIsValid(parent_relid)) return;
-
-	/* Fetch partitioning data */
-	prel = get_pathman_relation_info(parent_relid);
-
-	/* Skip if this table is not partitioned */
-	if (!prel) return;
+	char		   *old_constraint_name,
+				   *new_constraint_name;
+	RenameStmt		rename_stmt;
 
 	/* Generate old constraint name */
-	old_constraint_name = build_check_constraint_name_relid_internal(partition_relid,
-																	 prel->attnum);
+	old_constraint_name =
+			build_check_constraint_name_relid_internal(partition_relid,
+													   partitioned_col);
 
 	/* Generate new constraint name */
-	new_constraint_name = build_check_constraint_name_relname_internal(stmt->newname,
-																	   prel->attnum);
+	new_constraint_name =
+			build_check_constraint_name_relname_internal(part_rename_stmt->newname,
+														 partitioned_col);
 
 	/* Build check constraint RENAME statement */
-	rename_stmt = makeNode(RenameStmt);
-	rename_stmt->renameType = OBJECT_TABCONSTRAINT;
-	rename_stmt->relation = stmt->relation;
-	rename_stmt->subname = old_constraint_name;
-	rename_stmt->newname = new_constraint_name;
-	rename_stmt->missing_ok = false;
-
-	RenameConstraint(rename_stmt);
+	memset((void *) &rename_stmt, 0, sizeof(RenameStmt));
+	NodeSetTag(&rename_stmt, T_RenameStmt);
+	rename_stmt.renameType = OBJECT_TABCONSTRAINT;
+	rename_stmt.relation = part_rename_stmt->relation;
+	rename_stmt.subname = old_constraint_name;
+	rename_stmt.newname = new_constraint_name;
+	rename_stmt.missing_ok = false;
+
+	RenameConstraint(&rename_stmt);
 }
diff --git a/src/utility_stmt_hooking.h b/src/utility_stmt_hooking.h
@@ -1,7 +1,8 @@
 /* ------------------------------------------------------------------------
  *
  * utility_stmt_hooking.h
- *		Transaction-specific locks and other functions
+ *		Override COPY TO/FROM and ALTER TABLE ... RENAME statements
+ *		for partitioned tables
  *
  * Copyright (c) 2016, Postgres Professional
  *
@@ -17,8 +18,16 @@
 #include "nodes/nodes.h"
 
 
+/* Various traits */
 bool is_pathman_related_copy(Node *parsetree);
+bool is_pathman_related_table_rename(Node *parsetree,
+									 Oid *partition_relid_out,
+									 AttrNumber *partitioned_col_out);
+
+/* Statement handlers */
 void PathmanDoCopy(const CopyStmt *stmt, const char *queryString, uint64 *processed);
-void PathmanRenameConstraint(const RenameStmt *stmt);
+void PathmanRenameConstraint(Oid partition_relid,
+							 AttrNumber partitioned_col,
+							 const RenameStmt *partition_rename_stmt);
 
 #endif
diff --git a/src/utils.c b/src/utils.c
@@ -259,35 +259,6 @@ get_rel_owner(Oid relid)
 	return InvalidOid;
 }
 
-/*
- * Lookup for a parent table
- */
-Oid
-get_rel_parent(Oid relid)
-{
-	ScanKeyData		key[1];
-	Relation		relation;
-	HeapTuple		inheritsTuple;
-	Oid				inhparent = InvalidOid;
-	SysScanDesc		scan;
-
-	relation = heap_open(InheritsRelationId, AccessShareLock);
-	ScanKeyInit(&key[0],
-				Anum_pg_inherits_inhrelid,
-				BTEqualStrategyNumber, F_OIDEQ,
-				ObjectIdGetDatum(relid));
-	scan = systable_beginscan(relation, InvalidOid, false,
-							  NULL, 1, key);
-
-	if ((inheritsTuple = systable_getnext(scan)) != NULL)
-		inhparent = ((Form_pg_inherits) GETSTRUCT(inheritsTuple))->inhparent;
-
-	systable_endscan(scan);
-	heap_close(relation, AccessShareLock);
-
-	return inhparent;
-}
-
 /*
  * Checks that callback function meets specific requirements.
  * It must have the only JSONB argument and BOOL return type.
diff --git a/src/utils.h b/src/utils.h

Original file line number	Diff line number	Diff line change
`@@ -602,7 +602,7 @@ build_check_constraint_name_relid_internal(Oid relid, AttrNumber attno)`
`602`	`602`	`}`
`603`	`603`
`604`	`604`	`char *`
`605`		`-build_check_constraint_name_relname_internal(char *relname, AttrNumber attno)`
	`605`	`+build_check_constraint_name_relname_internal(const char *relname, AttrNumber attno)`
`606`	`606`	`{`
`607`	`607`	`return psprintf("pathman_%s_%u_check", relname, attno);`
`608`	`608`	`}`