Try to avoid compiler warnings in optimized builds.

robertmhaas · robertmhaas · commit 05021a2c0cd2 · 2020-04-24T14:11:45.000-04:00
Per report from Andres Freund, who also says that this fix works for him. Discussion: http://postgr.es/m/20200405193118.alprgmozhxcfabkw@alap3.anarazel.de
diff --git a/src/bin/pg_verifybackup/parse_manifest.h b/src/bin/pg_verifybackup/parse_manifest.h
@@ -29,7 +29,8 @@ typedef void (*json_manifest_perwalrange_callback)(JsonManifestParseContext *,
 								 TimeLineID tli,
 								 XLogRecPtr start_lsn, XLogRecPtr end_lsn);
 typedef void (*json_manifest_error_callback)(JsonManifestParseContext *,
-								 char *fmt, ...) pg_attribute_printf(2, 3);
+								 char *fmt, ...) pg_attribute_printf(2, 3)
+								 pg_attribute_noreturn();
 
 struct JsonManifestParseContext
 {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,8 @@ typedef void (json_manifest_perwalrange_callback)(JsonManifestParseContext ,`
`29`	`29`	`TimeLineID tli,`
`30`	`30`	`XLogRecPtr start_lsn, XLogRecPtr end_lsn);`
`31`	`31`	`typedef void (json_manifest_error_callback)(JsonManifestParseContext ,`
`32`		`- char *fmt, ...) pg_attribute_printf(2, 3);`
	`32`	`+ char *fmt, ...) pg_attribute_printf(2, 3)`
	`33`	`+ pg_attribute_noreturn();`
`33`	`34`
`34`	`35`	`struct JsonManifestParseContext`
`35`	`36`	`{`