Stop requiring an explicit return from perl subroutines

adunstan · adunstan · commit 0516f94d18c5 · 2020-04-14T16:55:34.000-04:00
The consensus of the project appears to be that this provides little benefit and is simply an annoyance. Discussion: https://postgr.es/m/27481.1586618092@sss.pgh.pa.us
diff --git a/src/tools/perlcheck/perlcriticrc b/src/tools/perlcheck/perlcriticrc
@@ -22,7 +22,3 @@ verbose = %f: %m at line %l, column %c.  %e.  ([%p] Severity: %s)\n
 # insist on use of the warnings pragma
 [TestingAndDebugging::RequireUseWarnings]
 severity = 5
-
-# for now raise severity of this to level 5
-[Subroutines::RequireFinalReturn]
-severity = 5
