More trivial dead code removal: in int_to_roman(), checking for "num == -1"

Neil Conway · Neil Conway · commit 06ecacded604 · 2005-06-22T01:43:05.000Z
is redundant after a check has already been made for "num &lt; 0". The "set"
variable can also be removed, as it is now no longer used. Per checking
with Karel, this is the right fix.

Per Coverity static analysis performed by EnterpriseDB.
diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
@@ -1,7 +1,7 @@
 /* -----------------------------------------------------------------------
  * formatting.c
  *
- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.88 2005/06/15 00:34:08 momjian Exp $
+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.89 2005/06/22 01:43:05 neilc Exp $
  *
  *
  *	 Portions Copyright (c) 1999-2005, PostgreSQL Global Development Group
@@ -3508,8 +3508,7 @@ static char *
 int_to_roman(int number)
 {
 	int			len = 0,
-				num = 0,
-				set = 0;
+				num = 0;
 	char	   *p = NULL,
 			   *result,
 				numstr[5];
@@ -3529,9 +3528,6 @@ int_to_roman(int number)
 		num = *p - 49;			/* 48 ascii + 1 */
 		if (num < 0)
 			continue;
-		if (num == -1 && set == 0)
-			continue;
-		set = 1;
 
 		if (len > 3)
 		{

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`/* -----------------------------------------------------------------------`
`2`	`2`	`* formatting.c`
`3`	`3`	`*`
`4`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.88 2005/06/15 00:34:08 momjian Exp $`
	`4`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/formatting.c,v 1.89 2005/06/22 01:43:05 neilc Exp $`
`5`	`5`	`*`
`6`	`6`	`*`
`7`	`7`	`* Portions Copyright (c) 1999-2005, PostgreSQL Global Development Group`
`@@ -3508,8 +3508,7 @@ static char *`
`3508`	`3508`	`int_to_roman(int number)`
`3509`	`3509`	`{`
`3510`	`3510`	`int len = 0,`
`3511`		`- num = 0,`
`3512`		`- set = 0;`
	`3511`	`+ num = 0;`
`3513`	`3512`	`char *p = NULL,`
`3514`	`3513`	`*result,`
`3515`	`3514`	`numstr[5];`
`@@ -3529,9 +3528,6 @@ int_to_roman(int number)`
`3529`	`3528`	`num = p - 49; / 48 ascii + 1 */`
`3530`	`3529`	`if (num < 0)`
`3531`	`3530`	`continue;`
`3532`		`- if (num == -1 && set == 0)`
`3533`		`- continue;`
`3534`		`- set = 1;`
`3535`	`3531`
`3536`	`3532`	`if (len > 3)`
`3537`	`3533`	`{`