Silence complaint about dead assignment

petere · petere · commit 07e524d3e955 · 2018-01-29T20:43:43.000-05:00
The preferred place for "placate compiler" assignments is after
elog(ERROR), not before it.  Otherwise, scan-build complains about a
dead assignment.
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -13251,8 +13251,8 @@ RangeVarCallbackForAlterRelation(const RangeVar *rv, Oid relid, Oid oldrelid,
 		reltype = ((AlterTableStmt *) stmt)->relkind;
 	else
 	{
-		reltype = OBJECT_TABLE; /* placate compiler */
 		elog(ERROR, "unrecognized node type: %d", (int) nodeTag(stmt));
+		reltype = OBJECT_TABLE; /* placate compiler */
 	}
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -13251,8 +13251,8 @@ RangeVarCallbackForAlterRelation(const RangeVar *rv, Oid relid, Oid oldrelid,`
`13251`	`13251`	`reltype = ((AlterTableStmt *) stmt)->relkind;`
`13252`	`13252`	`else`
`13253`	`13253`	`{`
`13254`		`- reltype = OBJECT_TABLE; /* placate compiler */`
`13255`	`13254`	`elog(ERROR, "unrecognized node type: %d", (int) nodeTag(stmt));`
	`13255`	`+ reltype = OBJECT_TABLE; /* placate compiler */`
`13256`	`13256`	`}`
`13257`	`13257`
`13258`	`13258`	`/*`