Fix relcache leaks in get_object_address_publication_rel()

petere · petere · commit 115cb31597fa · 2017-02-07T22:09:53.000-05:00
diff --git a/src/backend/catalog/objectaddress.c b/src/backend/catalog/objectaddress.c
@@ -1835,7 +1835,10 @@ get_object_address_publication_rel(List *objname, List *objargs,
 	/* Now look up the pg_publication tuple */
 	pub = GetPublicationByName(pubname, missing_ok);
 	if (!pub)
+	{
+		relation_close(relation, AccessShareLock);
 		return address;
+	}
 
 	/* Find the publication relation mapping in syscache. */
 	address.objectId =
@@ -1849,6 +1852,7 @@ get_object_address_publication_rel(List *objname, List *objargs,
 					(errcode(ERRCODE_UNDEFINED_OBJECT),
 					 errmsg("publication relation \"%s\" in publication \"%s\" does not exist",
 							RelationGetRelationName(relation), pubname)));
+		relation_close(relation, AccessShareLock);
 		return address;
 	}
 
