> I enclose a short patch to reduce the PGARCH_RESTART_INTERVAL from 60

bmomjian · bmomjian · commit 12e678201d05 · 2004-12-02T22:40:18.000Z
&gt; seconds to 10 seconds. The original number was plucked from thin air
&gt; some months ago, and I'd like to review that now based upon further
&gt; thought, observation and experience.
&gt;
&gt; This change has little or no effect on performance, since the interval
&gt; is there mainly to avoid repeated respawn attempts if archiver fails at
&gt; startup. Archiver start-up time is very quick, so there is little danger
&gt; of exceeding 10 seconds.
&gt;
&gt; On a busy system, if the archiver does die, then many files can build up
&gt; in the 60 seconds before respawning. That xlog file backlog could take
&gt; some time to clear. This then leaves a larger than normal window of data
&gt; loss for a possibly long period.
&gt;
&gt; It's a minor change only, with no other effect on function.

Simon Riggs
diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c
@@ -19,7 +19,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/pgarch.c,v 1.12 2004/11/18 17:13:38 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/pgarch.c,v 1.13 2004/12/02 22:40:18 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -51,7 +51,7 @@
 #define PGARCH_AUTOWAKE_INTERVAL 60		/* How often to force a poll of
 										 * the archive status directory;
 										 * in seconds. */
-#define PGARCH_RESTART_INTERVAL 60		/* How often to attempt to restart
+#define PGARCH_RESTART_INTERVAL 10		/* How often to attempt to restart
 										 * a failed archiver; in seconds. */
 
 /* ----------

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`*`
`20`	`20`	`*`
`21`	`21`	`* IDENTIFICATION`
`22`		`- * $PostgreSQL: pgsql/src/backend/postmaster/pgarch.c,v 1.12 2004/11/18 17:13:38 tgl Exp $`
	`22`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/pgarch.c,v 1.13 2004/12/02 22:40:18 momjian Exp $`
`23`	`23`	`*`
`24`	`24`	`*-------------------------------------------------------------------------`
`25`	`25`	`*/`
`@@ -51,7 +51,7 @@`
`51`	`51`	`#define PGARCH_AUTOWAKE_INTERVAL 60 /* How often to force a poll of`
`52`	`52`	`* the archive status directory;`
`53`	`53`	`* in seconds. */`
`54`		`-#define PGARCH_RESTART_INTERVAL 60 /* How often to attempt to restart`
	`54`	`+#define PGARCH_RESTART_INTERVAL 10 /* How often to attempt to restart`
`55`	`55`	`* a failed archiver; in seconds. */`
`56`	`56`
`57`	`57`	`/* ----------`