I am sorry, I misinterpreted the still failing trigger regression test.

bmomjian · bmomjian · commit 1a87c14c9cf2 · 1999-05-12T12:47:24.000Z
The
offending code
has been removed, the action is now always dependent :-)

I suggest the following patch, to finally make trigger regression happy
again:

 &lt;&lt;refint1.patch&gt;&gt;
After that you can remove the following from TODO:
Remove ERROR:  check_primary_key: even number of arguments should be
specified
Trigger regression test fails

Andreas
diff --git a/contrib/spi/refint.c b/contrib/spi/refint.c
@@ -3,8 +3,6 @@
  *		constraints using general triggers.
  */
 
-#define  DEBUG_QUERY 1
-
 #include "executor/spi.h"		/* this is what you need to work with SPI */
 #include "commands/trigger.h"	/* -"- and triggers */
 #include <ctype.h>				/* tolower () */
diff --git a/src/backend/utils/adt/acl.c b/src/backend/utils/adt/acl.c
@@ -7,7 +7,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.34 1999/03/21 06:31:59 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.35 1999/05/12 12:47:24 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -108,7 +108,7 @@ aclparse(char *s, AclItem *aip, unsigned *modechg)
 
 #ifdef ACLDEBUG_TRACE
 	printf("aclparse: input = '%s'\n", s);
-#endif ACLDEBUG_TRACE
+#endif
 	aip->ai_idtype = ACL_IDTYPE_UID;
 	s = getid(s, name);
 	if (*s != ACL_MODECHG_ADD_CHR &&

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`*`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.34 1999/03/21 06:31:59 momjian Exp $`
	`10`	`+ * $Header: /cvsroot/pgsql/src/backend/utils/adt/acl.c,v 1.35 1999/05/12 12:47:24 momjian Exp $`
`11`	`11`	`*`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`@@ -108,7 +108,7 @@ aclparse(char s, AclItem aip, unsigned *modechg)`
`108`	`108`
`109`	`109`	`#ifdef ACLDEBUG_TRACE`
`110`	`110`	`printf("aclparse: input = '%s'\n", s);`
`111`		`-#endif ACLDEBUG_TRACE`
	`111`	`+#endif`
`112`	`112`	`aip->ai_idtype = ACL_IDTYPE_UID;`
`113`	`113`	`s = getid(s, name);`
`114`	`114`	`if (*s != ACL_MODECHG_ADD_CHR &&`