Avoid hanging on exit in pglogical_receiver

knizhnik · kelvich · commit 1df51e388b98 · 2017-11-13T02:17:30.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -2334,7 +2334,7 @@ void MtmReceiverStarted(int nodeId)
 MtmReplicationMode MtmGetReplicationMode(int nodeId)
 {
 	bool recovery = false;
-	while (Mtm->status != MTM_CONNECTED && Mtm->status != MTM_ONLINE) { 		
+	if (Mtm->status != MTM_CONNECTED && Mtm->status != MTM_ONLINE) { 		
 		MTM_LOG2("%d: receiver slot mode %s", MyProcPid, MtmNodeStatusMnem[Mtm->status]);
 		if (Mtm->status == MTM_RECOVERY) { 
 			recovery = true;
@@ -2351,6 +2351,7 @@ MtmReplicationMode MtmGetReplicationMode(int nodeId)
 		}
 		/* delay opening of other slots until recovery is completed */
 		MtmSleep(STATUS_POLL_DELAY);
+		return REPLMODE_UNKNOWN;
 	}
 	if (recovery) { 
 		MTM_LOG1("Recreate replication slot for node %d after end of recovery", nodeId);
diff --git a/multimaster.h b/multimaster.h
@@ -117,6 +117,7 @@ typedef enum
 
 typedef enum
 {
+	REPLMODE_UNKNOWN,    /* receiver should wait */
 	REPLMODE_RECOVERED,  /* recovery of node is completed so drop old slot and restart replication from the current position in WAL */
 	REPLMODE_RECOVERY,   /* perform recorvery of the node by applying all data from the slot from specified point */
 	REPLMODE_NORMAL      /* normal mode: use existed slot or create new one and start receiving data from it from the specified position */

Original file line number	Diff line number	Diff line change
`@@ -2334,7 +2334,7 @@ void MtmReceiverStarted(int nodeId)`
`2334`	`2334`	`MtmReplicationMode MtmGetReplicationMode(int nodeId)`
`2335`	`2335`	`{`
`2336`	`2336`	`bool recovery = false;`
`2337`		`- while (Mtm->status != MTM_CONNECTED && Mtm->status != MTM_ONLINE) {`
	`2337`	`+ if (Mtm->status != MTM_CONNECTED && Mtm->status != MTM_ONLINE) {`
`2338`	`2338`	`MTM_LOG2("%d: receiver slot mode %s", MyProcPid, MtmNodeStatusMnem[Mtm->status]);`
`2339`	`2339`	`if (Mtm->status == MTM_RECOVERY) {`
`2340`	`2340`	`recovery = true;`
`@@ -2351,6 +2351,7 @@ MtmReplicationMode MtmGetReplicationMode(int nodeId)`
`2351`	`2351`	`}`
`2352`	`2352`	`/* delay opening of other slots until recovery is completed */`
`2353`	`2353`	`MtmSleep(STATUS_POLL_DELAY);`
	`2354`	`+ return REPLMODE_UNKNOWN;`
`2354`	`2355`	`}`
`2355`	`2356`	`if (recovery) {`
`2356`	`2357`	`MTM_LOG1("Recreate replication slot for node %d after end of recovery", nodeId);`
Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,7 @@ typedef enum`
`117`	`117`
`118`	`118`	`typedef enum`
`119`	`119`	`{`
	`120`	`+ REPLMODE_UNKNOWN, /* receiver should wait */`
`120`	`121`	`REPLMODE_RECOVERED, /* recovery of node is completed so drop old slot and restart replication from the current position in WAL */`
`121`	`122`	`REPLMODE_RECOVERY, /* perform recorvery of the node by applying all data from the slot from specified point */`
`122`	`123`	`REPLMODE_NORMAL /* normal mode: use existed slot or create new one and start receiving data from it from the specified position */`