Fix overflow in extract(epoch from interval) for intervals exceeding 68 years.

tglsfdc · tglsfdc · commit 22d98e793430 · 2007-09-16T15:56:20.000Z
Seems to have been introduced in 8.1 by careless SECS_PER_DAY
search-and-replace.
diff --git a/src/backend/utils/adt/timestamp.c b/src/backend/utils/adt/timestamp.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.181 2007/08/04 01:26:54 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.182 2007/09/16 15:56:20 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -4395,9 +4395,9 @@ interval_part(PG_FUNCTION_ARGS)
 #else
 		result = interval->time;
 #endif
-		result += (DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
+		result += ((double) DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);
 		result += ((double) DAYS_PER_MONTH * SECS_PER_DAY) * (interval->month % MONTHS_PER_YEAR);
-		result += interval->day * SECS_PER_DAY;
+		result += ((double) SECS_PER_DAY) * interval->day;
 	}
 	else
 	{

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.181 2007/08/04 01:26:54 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/timestamp.c,v 1.182 2007/09/16 15:56:20 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*-------------------------------------------------------------------------`
`14`	`14`	`*/`
`@@ -4395,9 +4395,9 @@ interval_part(PG_FUNCTION_ARGS)`
`4395`	`4395`	`#else`
`4396`	`4396`	`result = interval->time;`
`4397`	`4397`	`#endif`
`4398`		`- result += (DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);`
	`4398`	`+ result += ((double) DAYS_PER_YEAR * SECS_PER_DAY) * (interval->month / MONTHS_PER_YEAR);`
`4399`	`4399`	`result += ((double) DAYS_PER_MONTH * SECS_PER_DAY) * (interval->month % MONTHS_PER_YEAR);`
`4400`		`- result += interval->day * SECS_PER_DAY;`
	`4400`	`+ result += ((double) SECS_PER_DAY) * interval->day;`
`4401`	`4401`	`}`
`4402`	`4402`	`else`
`4403`	`4403`	`{`