Handle PREPARE message for aborted transactions at slaves

knizhnik · kelvich · commit 23c06aa78c5c · 2017-11-13T00:17:08.000+03:00
diff --git a/arbiter.c b/arbiter.c
@@ -904,11 +904,15 @@ static void MtmTransReceiver(Datum arg)
 					} else { 
 						switch (msg->code) { 
 						  case MSG_PREPARE:
-							Assert(ts->status == TRANSACTION_STATUS_IN_PROGRESS); 	
-							ts->status = TRANSACTION_STATUS_UNKNOWN;
-							ts->csn = MtmAssignCSN();
-							MtmAdjustSubtransactions(ts);
-							MtmSendNotificationMessage(ts, MSG_PREPARED);
+							if (ts->status == TRANSACTION_STATUS_IN_PROGRESS) { 
+								ts->status = TRANSACTION_STATUS_UNKNOWN;
+								ts->csn = MtmAssignCSN();
+								MtmAdjustSubtransactions(ts);
+								MtmSendNotificationMessage(ts, MSG_PREPARED);
+							} else {
+								Assert(ts->status == TRANSACTION_STATUS_ABORTED);
+								MtmSendNotificationMessage(ts, MSG_ABORTED);
+							}
 							break;
 						  default:
 							Assert(false);
diff --git a/multimaster.c b/multimaster.c
@@ -195,7 +195,6 @@ int   MtmReplicationNodeId;
 int   MtmArbiterPort;
 int   MtmConnectTimeout;
 int   MtmReconnectTimeout;
-int   MtmRaftPollDelay;
 int   MtmNodeDisableDelay;
 int   MtmTransSpillThreshold;
 int   MtmMaxNodes;
@@ -736,7 +735,7 @@ MtmPrePrepareTransaction(MtmCurrentTrans* x)
 
 	if (Mtm->disabledNodeMask != 0) { 
 		timestamp_t now = MtmGetSystemTime();		
-		if (Mtm->lastClusterStatusUpdate + MSEC_TO_USEC(MtmRaftPollDelay) < now) { 
+		if (Mtm->lastClusterStatusUpdate + MSEC_TO_USEC(MtmHeartbeatRecvTimeout) < now) { 
 			Mtm->lastClusterStatusUpdate = now;
 			MtmRefreshClusterStatus(true);
 		}
@@ -1438,7 +1437,7 @@ void MtmOnNodeDisconnect(int nodeId)
 
 	RaftableSet(psprintf("node-mask-%d", MtmNodeId), &Mtm->connectivityMask, sizeof Mtm->connectivityMask, true); /* false); -- TODO: raftable is hanged with nowait=true */
 
-	MtmSleep(MSEC_TO_USEC(MtmRaftPollDelay));
+	MtmSleep(MSEC_TO_USEC(MtmHeartbeatSendTimeout));
 
 	if (!MtmUseRaftable) 
 	{
@@ -2059,22 +2058,6 @@ _PG_init(void)
 		NULL
 	);
 
-	DefineCustomIntVariable(
-		"multimaster.raft_poll_delay",
-		"Multimaster delay of polling cluster state from Raftable after updating local node status",
-		"Timeout in milliseconds before polling state of nodes",
-		&MtmRaftPollDelay,
-		1000,
-		1,
-		INT_MAX,
-		PGC_BACKEND,
-		0,
-		NULL,
-		NULL,
-		NULL
-	);
-
-
 	MtmSplitConnStrs();
     MtmStartReceivers();
 		
