Fix rounding problem in dynahash.c's decision about when the target

tglsfdc · tglsfdc · commit 294c34bb9d8e · 2004-11-21T22:57:00.000Z
fill factor has been exceeded.  We usually run with ffactor == 1, but
the way the test was coded, it wouldn't split a bucket until the actual
fill factor reached 2.0, because of use of integer division.  Change
from &gt; to &gt;= so that it will split more aggressively when the table
starts to get full.
diff --git a/src/backend/utils/hash/dynahash.c b/src/backend/utils/hash/dynahash.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.56 2004/10/25 00:46:43 neilc Exp $
+ *	  $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.57 2004/11/21 22:57:00 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -662,7 +662,7 @@ hash_search(HTAB *hashp,
 			/* caller is expected to fill the data field on return */
 
 			/* Check if it is time to split the segment */
-			if (++hctl->nentries / (long) (hctl->max_bucket + 1) > hctl->ffactor)
+			if (++hctl->nentries / (long) (hctl->max_bucket + 1) >= hctl->ffactor)
 			{
 				/*
 				 * NOTE: failure to expand table is not a fatal error, it

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.56 2004/10/25 00:46:43 neilc Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/hash/dynahash.c,v 1.57 2004/11/21 22:57:00 tgl Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -662,7 +662,7 @@ hash_search(HTAB *hashp,`
`662`	`662`	`/* caller is expected to fill the data field on return */`
`663`	`663`
`664`	`664`	`/* Check if it is time to split the segment */`
`665`		`- if (++hctl->nentries / (long) (hctl->max_bucket + 1) > hctl->ffactor)`
	`665`	`+ if (++hctl->nentries / (long) (hctl->max_bucket + 1) >= hctl->ffactor)`
`666`	`666`	`{`
`667`	`667`	`/*`
`668`	`668`	`* NOTE: failure to expand table is not a fatal error, it`