Use ssize_t where signed results can happen

mhagander · mhagander · commit 2dde01ccbfb4 · 2016-10-24T20:10:18.000+02:00
Noted by Alexander Korotkov
diff --git a/src/bin/pg_basebackup/walmethods.c b/src/bin/pg_basebackup/walmethods.c
@@ -432,7 +432,7 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)
 	{
 		size_t		bytestowrite = bytesleft > XLOG_BLCKSZ ? XLOG_BLCKSZ : bytesleft;
 
-		size_t		r = tar_write(f, zerobuf, bytestowrite);
+		ssize_t		r = tar_write(f, zerobuf, bytestowrite);
 
 		if (r < 0)
 			return false;

Original file line number	Diff line number	Diff line change
`@@ -432,7 +432,7 @@ tar_write_padding_data(TarMethodFile * f, size_t bytes)`
`432`	`432`	`{`
`433`	`433`	`size_t bytestowrite = bytesleft > XLOG_BLCKSZ ? XLOG_BLCKSZ : bytesleft;`
`434`	`434`
`435`		`- size_t r = tar_write(f, zerobuf, bytestowrite);`
	`435`	`+ ssize_t r = tar_write(f, zerobuf, bytestowrite);`
`436`	`436`
`437`	`437`	`if (r < 0)`
`438`	`438`	`return false;`