Commit 2eafcf6

committed

Restructure the code in copyfuncs and equalfuncs to put much heavier

reliance on macros, in hopes of eliminating silly typos (like copying to the wrong field) and just generally making it easier to see the forest instead of the trees. As an example, here is the new code for A_Indices: static A_Indices * _copyAIndices(A_Indices *from) { A_Indices *newnode = makeNode(A_Indices); COPY_NODE_FIELD(lidx); COPY_NODE_FIELD(uidx); return newnode; } static bool _equalAIndices(A_Indices *a, A_Indices *b) { COMPARE_NODE_FIELD(lidx); COMPARE_NODE_FIELD(uidx); return true; } I plan to redo outfuncs/readfuncs in a similar style, but am committing what I've got.

1 parent 200dd8e commit 2eafcf6Copy full SHA for 2eafcf6

2 files changed

+1474

-2065

lines changed

src/backend/nodes
- copyfuncs.c
- equalfuncs.c

2 files changed

+1474

-2065

lines changed

Comments

(0)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 2eafcf6

2 files changed

2 files changed

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

File tree

2 files changed

2 files changed

0 commit comments

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.