Make the bgwriter's error recovery path do smgrcloseall(). On Windows this

tglsfdc · tglsfdc · commit 3049fe7cfa99 · 2006-12-01T19:55:28.000Z
should allow delete-pending files to actually go away, and thereby work
around the various complaints we've seen about 'permission denied'
errors in such cases.  Should be reasonably harmless in any case...
diff --git a/src/backend/postmaster/bgwriter.c b/src/backend/postmaster/bgwriter.c
@@ -37,7 +37,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.32 2006/11/30 18:29:12 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.33 2006/12/01 19:55:28 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -304,6 +304,13 @@ BackgroundWriterMain(void)
 		 * fast as we can.
 		 */
 		pg_usleep(1000000L);
+
+		/*
+		 * Close all open files after any error.  This is helpful on Windows,
+		 * where holding deleted files open causes various strange errors.
+		 * It's not clear we need it elsewhere, but shouldn't hurt.
+		 */
+		smgrcloseall();
 	}
 
 	/* We can now handle ereport(ERROR) */

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`	`*`
`38`	`38`	`*`
`39`	`39`	`* IDENTIFICATION`
`40`		`- * $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.32 2006/11/30 18:29:12 tgl Exp $`
	`40`	`+ * $PostgreSQL: pgsql/src/backend/postmaster/bgwriter.c,v 1.33 2006/12/01 19:55:28 tgl Exp $`
`41`	`41`	`*`
`42`	`42`	`*-------------------------------------------------------------------------`
`43`	`43`	`*/`
`@@ -304,6 +304,13 @@ BackgroundWriterMain(void)`
`304`	`304`	`* fast as we can.`
`305`	`305`	`*/`
`306`	`306`	`pg_usleep(1000000L);`
	`307`	`+`
	`308`	`+ /*`
	`309`	`+ * Close all open files after any error. This is helpful on Windows,`
	`310`	`+ * where holding deleted files open causes various strange errors.`
	`311`	`+ * It's not clear we need it elsewhere, but shouldn't hurt.`
	`312`	`+ */`
	`313`	`+ smgrcloseall();`
`307`	`314`	`}`
`308`	`315`
`309`	`316`	`/* We can now handle ereport(ERROR) */`