Remove unnecessary calls of FlushRelationBuffers: there is no need

tglsfdc · tglsfdc · commit 354049c709c9 · 2005-03-20T22:00:54.000Z
to write out data that we are about to tell the filesystem to drop.
smgr_internal_unlink already had a DropRelFileNodeBuffers call to
get rid of dead buffers without a write after it's no longer possible
to roll back the deleting transaction.  Adding a similar call in
smgrtruncate simplifies callers and makes the overall division of
labor clearer.  This patch removes the former behavior that VACUUM
would write all dirty buffers of a relation unconditionally.
diff --git a/src/backend/access/nbtree/nbtree.c b/src/backend/access/nbtree/nbtree.c
@@ -12,7 +12,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/access/nbtree/nbtree.c,v 1.124 2004/12/31 21:59:22 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/access/nbtree/nbtree.c,v 1.125 2005/03/20 22:00:50 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -772,17 +772,6 @@ btvacuumcleanup(PG_FUNCTION_ARGS)
 		{
 			/*
 			 * Okay to truncate.
-			 *
-			 * First, flush any shared buffers for the blocks we intend to
-			 * delete.	FlushRelationBuffers is a bit more than we need
-			 * for this, since it will also write out dirty buffers for
-			 * blocks we aren't deleting, but it's the closest thing in
-			 * bufmgr's API.
-			 */
-			FlushRelationBuffers(rel, new_pages);
-
-			/*
-			 * Do the physical truncation.
 			 */
 			RelationTruncate(rel, new_pages);
 
diff --git a/src/backend/catalog/heap.c b/src/backend/catalog/heap.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/heap.c,v 1.280 2005/01/27 03:17:17 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/heap.c,v 1.281 2005/03/20 22:00:51 tgl Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -1174,12 +1174,6 @@ heap_drop_with_catalog(Oid relid)
 	 */
 	rel = relation_open(relid, AccessExclusiveLock);
 
-	/*
-	 * Release all buffers that belong to this relation, after writing any
-	 * that are dirty
-	 */
-	FlushRelationBuffers(rel, (BlockNumber) 0);
-
 	/*
 	 * Schedule unlinking of the relation's physical file at commit.
 	 */
@@ -1958,13 +1952,7 @@ RelationTruncateIndexes(Oid heapId)
 		/* Fetch info needed for index_build */
 		indexInfo = BuildIndexInfo(currentIndex);
 
-		/*
-		 * Drop any buffers associated with this index. If they're dirty,
-		 * they're just dropped without bothering to flush to disk.
-		 */
-		DropRelationBuffers(currentIndex);
-
-		/* Now truncate the actual data */
+		/* Now truncate the actual file (and discard buffers) */
 		RelationTruncate(currentIndex, 0);
 
 		/* Initialize the index and rebuild */
@@ -2024,13 +2012,7 @@ heap_truncate(List *relids)
 	{
 		Relation	rel = lfirst(cell);
 
-		/*
-		 * Release any buffers associated with this relation.  If they're
-		 * dirty, they're just dropped without bothering to flush to disk.
-		 */
-		DropRelationBuffers(rel);
-
-		/* Now truncate the actual data */
+		/* Truncate the actual file (and discard buffers) */
 		RelationTruncate(rel, 0);
 
 		/* If this relation has indexes, truncate the indexes too */
diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.247 2005/03/16 21:38:04 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.248 2005/03/20 22:00:51 tgl Exp $
  *
  *
  * INTERFACE ROUTINES
@@ -775,10 +775,8 @@ index_drop(Oid indexId)
 	LockRelation(userIndexRelation, AccessExclusiveLock);
 
 	/*
-	 * flush buffer cache and schedule physical removal of the file
+	 * Schedule physical removal of the file
 	 */
-	FlushRelationBuffers(userIndexRelation, (BlockNumber) 0);
-
 	RelationOpenSmgr(userIndexRelation);
 	smgrscheduleunlink(userIndexRelation->rd_smgr,
 					   userIndexRelation->rd_istemp);
@@ -1617,14 +1615,7 @@ reindex_index(Oid indexId)
 
 		if (inplace)
 		{
-			/*
-			 * Release any buffers associated with this index.	If they're
-			 * dirty, they're just dropped without bothering to flush to
-			 * disk.
-			 */
-			DropRelationBuffers(iRel);
-
-			/* Now truncate the actual data */
+			/* Truncate the actual file (and discard buffers) */
 			RelationTruncate(iRel, 0);
 		}
 		else
diff --git a/src/backend/commands/cluster.c b/src/backend/commands/cluster.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/cluster.c,v 1.132 2005/02/06 20:19:08 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/cluster.c,v 1.133 2005/03/20 22:00:52 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -709,8 +709,7 @@ copy_heap_data(Oid OIDNewHeap, Oid OIDOldHeap, Oid OIDOldIndex)
 void
 swap_relation_files(Oid r1, Oid r2)
 {
-	Relation	relRelation,
-				rel;
+	Relation	relRelation;
 	HeapTuple	reltup1,
 				reltup2;
 	Form_pg_class relform1,
@@ -735,20 +734,6 @@ swap_relation_files(Oid r1, Oid r2)
 		elog(ERROR, "cache lookup failed for relation %u", r2);
 	relform2 = (Form_pg_class) GETSTRUCT(reltup2);
 
-	/*
-	 * The buffer manager gets confused if we swap relfilenodes for
-	 * relations that are not both local or non-local to this transaction.
-	 * Flush the buffers on both relations so the buffer manager can
-	 * forget about'em.  (XXX this might not be necessary anymore?)
-	 */
-	rel = relation_open(r1, NoLock);
-	FlushRelationBuffers(rel, 0);
-	relation_close(rel, NoLock);
-
-	rel = relation_open(r2, NoLock);
-	FlushRelationBuffers(rel, 0);
-	relation_close(rel, NoLock);
-
 	/*
 	 * Actually swap the fields in the two tuples
 	 */
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.147 2005/03/16 21:38:05 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/tablecmds.c,v 1.148 2005/03/20 22:00:52 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -5628,13 +5628,12 @@ copy_relation_data(Relation rel, SMgrRelation dst)
 	Page		page = (Page) buf;
 
 	/*
-	 * Since we copy the data directly without looking at the shared
+	 * Since we copy the file directly without looking at the shared
 	 * buffers, we'd better first flush out any pages of the source
-	 * relation that are in shared buffers.  We assume no new pages will
-	 * get loaded into buffers while we are holding exclusive lock on the
-	 * rel.
+	 * relation that are in shared buffers.  We assume no new changes
+	 * will be made while we are holding exclusive lock on the rel.
 	 */
-	FlushRelationBuffers(rel, 0);
+	FlushRelationBuffers(rel);
 
 	/*
 	 * We need to log the copied data in WAL iff WAL archiving is enabled
diff --git a/src/backend/commands/vacuum.c b/src/backend/commands/vacuum.c
@@ -13,7 +13,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.304 2005/03/16 21:38:05 tgl Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/vacuum.c,v 1.305 2005/03/20 22:00:52 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1138,16 +1138,6 @@ full_vacuum_rel(Relation onerel, VacuumStmt *vacstmt)
 			/* Clean pages from vacuum_pages list */
 			vacuum_heap(vacrelstats, onerel, &vacuum_pages);
 		}
-		else
-		{
-			/*
-			 * Flush dirty pages out to disk.  We must do this even if we
-			 * didn't do anything else, because we want to ensure that all
-			 * tuples have correct on-row commit status on disk (see
-			 * bufmgr.c's comments for FlushRelationBuffers()).
-			 */
-			FlushRelationBuffers(onerel, vacrelstats->rel_pages);
-		}
 	}
 
 	/* update shared free space map with final free space info */
@@ -2420,15 +2410,7 @@ repair_frag(VRelStats *vacrelstats, Relation onerel,
 		pfree(Nvacpagelist.pagedesc);
 	}
 
-	/*
-	 * Flush dirty pages out to disk.  We do this unconditionally, even if
-	 * we don't need to truncate, because we want to ensure that all
-	 * tuples have correct on-row commit status on disk (see bufmgr.c's
-	 * comments for FlushRelationBuffers()).
-	 */
-	FlushRelationBuffers(onerel, blkno);
-
-	/* truncate relation, if needed */
+	/* Truncate relation, if needed */
 	if (blkno < nblocks)
 	{
 		RelationTruncate(onerel, blkno);
@@ -2818,27 +2800,17 @@ vacuum_heap(VRelStats *vacrelstats, Relation onerel, VacPageList vacuum_pages)
 		}
 	}
 
-	/*
-	 * Flush dirty pages out to disk.  We do this unconditionally, even if
-	 * we don't need to truncate, because we want to ensure that all
-	 * tuples have correct on-row commit status on disk (see bufmgr.c's
-	 * comments for FlushRelationBuffers()).
-	 */
+	/* Truncate relation if there are some empty end-pages */
 	Assert(vacrelstats->rel_pages >= vacuum_pages->empty_end_pages);
-	relblocks = vacrelstats->rel_pages - vacuum_pages->empty_end_pages;
-
-	FlushRelationBuffers(onerel, relblocks);
-
-	/* truncate relation if there are some empty end-pages */
 	if (vacuum_pages->empty_end_pages > 0)
 	{
+		relblocks = vacrelstats->rel_pages - vacuum_pages->empty_end_pages;
 		ereport(elevel,
 				(errmsg("\"%s\": truncated %u to %u pages",
 						RelationGetRelationName(onerel),
 						vacrelstats->rel_pages, relblocks)));
 		RelationTruncate(onerel, relblocks);
-		vacrelstats->rel_pages = relblocks;		/* set new number of
-												 * blocks */
+		vacrelstats->rel_pages = relblocks;		/* set new number of blocks */
 	}
 }
 
diff --git a/src/backend/commands/vacuumlazy.c b/src/backend/commands/vacuumlazy.c
@@ -31,7 +31,7 @@
  *
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/commands/vacuumlazy.c,v 1.50 2004/12/31 21:59:42 pgsql Exp $
+ *	  $PostgreSQL: pgsql/src/backend/commands/vacuumlazy.c,v 1.51 2005/03/20 22:00:52 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -773,16 +773,6 @@ lazy_truncate_heap(Relation onerel, LVRelStats *vacrelstats)
 
 	/*
 	 * Okay to truncate.
-	 *
-	 * First, flush any shared buffers for the blocks we intend to delete.
-	 * FlushRelationBuffers is a bit more than we need for this, since it
-	 * will also write out dirty buffers for blocks we aren't deleting,
-	 * but it's the closest thing in bufmgr's API.
-	 */
-	FlushRelationBuffers(onerel, new_rel_pages);
-
-	/*
-	 * Do the physical truncation.
 	 */
 	RelationTruncate(onerel, new_rel_pages);
 
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
diff --git a/src/backend/storage/smgr/smgr.c b/src/backend/storage/smgr/smgr.c
diff --git a/src/include/storage/bufmgr.h b/src/include/storage/bufmgr.h

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`*`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.247 2005/03/16 21:38:04 tgl Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/catalog/index.c,v 1.248 2005/03/20 22:00:51 tgl Exp $`
`12`	`12`	`*`
`13`	`13`	`*`
`14`	`14`	`* INTERFACE ROUTINES`
`@@ -775,10 +775,8 @@ index_drop(Oid indexId)`
`775`	`775`	`LockRelation(userIndexRelation, AccessExclusiveLock);`
`776`	`776`
`777`	`777`	`/*`
`778`		`- * flush buffer cache and schedule physical removal of the file`
	`778`	`+ * Schedule physical removal of the file`
`779`	`779`	`*/`
`780`		`- FlushRelationBuffers(userIndexRelation, (BlockNumber) 0);`
`781`		`-`
`782`	`780`	`RelationOpenSmgr(userIndexRelation);`
`783`	`781`	`smgrscheduleunlink(userIndexRelation->rd_smgr,`
`784`	`782`	`userIndexRelation->rd_istemp);`
`@@ -1617,14 +1615,7 @@ reindex_index(Oid indexId)`
`1617`	`1615`
`1618`	`1616`	`if (inplace)`
`1619`	`1617`	`{`
`1620`		`- /*`
`1621`		`- * Release any buffers associated with this index. If they're`
`1622`		`- * dirty, they're just dropped without bothering to flush to`
`1623`		`- * disk.`
`1624`		`- */`
`1625`		`- DropRelationBuffers(iRel);`
`1626`		`-`
`1627`		`- /* Now truncate the actual data */`
	`1618`	`+ /* Truncate the actual file (and discard buffers) */`
`1628`	`1619`	`RelationTruncate(iRel, 0);`
`1629`	`1620`	`}`
`1630`	`1621`	`else`