Allow pg_upgrade to upgrade clusters that use exclusion contraints by

bmomjian · bmomjian · commit 35e27226b675 · 2011-11-25T14:40:27.000-05:00
fixing pg_dump to properly preserve such indexes.

Backpatch to 9.1 and 9.0 (where the bug was introduced).
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12948,7 +12948,7 @@ dumpConstraint(Archive *fout, ConstraintInfo *coninfo)
 			exit_nicely();
 		}
 
-		if (binary_upgrade && !coninfo->condef)
+		if (binary_upgrade)
 			binary_upgrade_set_pg_class_oids(q, indxinfo->dobj.catId.oid, true);
 
 		appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",

Original file line number	Diff line number	Diff line change
`@@ -12948,7 +12948,7 @@ dumpConstraint(Archive fout, ConstraintInfo coninfo)`
`12948`	`12948`	`exit_nicely();`
`12949`	`12949`	`}`
`12950`	`12950`
`12951`		`- if (binary_upgrade && !coninfo->condef)`
	`12951`	`+ if (binary_upgrade)`
`12952`	`12952`	`binary_upgrade_set_pg_class_oids(q, indxinfo->dobj.catId.oid, true);`
`12953`	`12953`
`12954`	`12954`	`appendPQExpBuffer(q, "ALTER TABLE ONLY %s\n",`