Add C comment about \copy bug in CSV mode

bmomjian · bmomjian · commit 361b94c4b98b · 2013-07-04T13:09:52.000-04:00
Comment: This code erroneously assumes '\.' on a line alone inside a quoted CSV string terminates the \copy. http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org
diff --git a/src/bin/psql/copy.c b/src/bin/psql/copy.c
@@ -635,6 +635,11 @@ handleCopyIn(PGconn *conn, FILE *copystream, bool isbinary)
 				/* check for EOF marker, but not on a partial line */
 				if (firstload)
 				{
+					/*
+					 * This code erroneously assumes '\.' on a line alone
+					 * inside a quoted CSV string terminates the \copy.
+					 * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org
+					 */
 					if (strcmp(buf, "\\.\n") == 0 ||
 						strcmp(buf, "\\.\r\n") == 0)
 					{

Original file line number	Diff line number	Diff line change
`@@ -635,6 +635,11 @@ handleCopyIn(PGconn conn, FILE copystream, bool isbinary)`
`635`	`635`	`/* check for EOF marker, but not on a partial line */`
`636`	`636`	`if (firstload)`
`637`	`637`	`{`
	`638`	`+ /*`
	`639`	`+ * This code erroneously assumes '\.' on a line alone`
	`640`	`+ * inside a quoted CSV string terminates the \copy.`
	`641`	`+ * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org`
	`642`	`+ */`
`638`	`643`	`if (strcmp(buf, "\\.\n") == 0 \|\|`
`639`	`644`	`strcmp(buf, "\\.\r\n") == 0)`
`640`	`645`	`{`