Prevent core dump from calling Tcl_DontCallWhenDeleted() with a null

tglsfdc · tglsfdc · commit 361eaa185f7b · 2003-02-01T00:22:12.000Z
interp pointer.  Per report from Gerhard Hintermayer.
diff --git a/src/interfaces/libpgtcl/pgtclId.c b/src/interfaces/libpgtcl/pgtclId.c
@@ -13,7 +13,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclId.c,v 1.39 2003/02/01 00:07:03 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclId.c,v 1.40 2003/02/01 00:22:12 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -274,8 +274,9 @@ PgDelConnectionId(DRIVER_DEL_PROTO)
 		Tcl_DeleteHashTable(&notifies->notify_hash);
 		if (notifies->conn_loss_cmd)
 			ckfree((void *) notifies->conn_loss_cmd);
-		Tcl_DontCallWhenDeleted(notifies->interp, PgNotifyInterpDelete,
-								(ClientData) notifies);
+		if (notifies->interp)
+			Tcl_DontCallWhenDeleted(notifies->interp, PgNotifyInterpDelete,
+									(ClientData) notifies);
 		ckfree((void *) notifies);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`* Portions Copyright (c) 1994, Regents of the University of California`
`14`	`14`	`*`
`15`	`15`	`* IDENTIFICATION`
`16`		`- * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclId.c,v 1.39 2003/02/01 00:07:03 tgl Exp $`
	`16`	`+ * $Header: /cvsroot/pgsql/src/interfaces/libpgtcl/Attic/pgtclId.c,v 1.40 2003/02/01 00:22:12 tgl Exp $`
`17`	`17`	`*`
`18`	`18`	`*-------------------------------------------------------------------------`
`19`	`19`	`*/`
`@@ -274,8 +274,9 @@ PgDelConnectionId(DRIVER_DEL_PROTO)`
`274`	`274`	`Tcl_DeleteHashTable(&notifies->notify_hash);`
`275`	`275`	`if (notifies->conn_loss_cmd)`
`276`	`276`	`ckfree((void *) notifies->conn_loss_cmd);`
`277`		`- Tcl_DontCallWhenDeleted(notifies->interp, PgNotifyInterpDelete,`
`278`		`- (ClientData) notifies);`
	`277`	`+ if (notifies->interp)`
	`278`	`+ Tcl_DontCallWhenDeleted(notifies->interp, PgNotifyInterpDelete,`
	`279`	`+ (ClientData) notifies);`
`279`	`280`	`ckfree((void *) notifies);`
`280`	`281`	`}`
`281`	`282`