We don't need to rebuild objfiles.txt every time an object file changes.

petere · petere · commit 3690019da8b6 · 2008-02-26T07:20:38.000Z
So only rebuild when a makefile changes (which presumably defines the
file list somewhere), and only touch the file if an object changed. The
touch is necessary so the parent make knows something changed and
ultimately rebuilds postgres.
diff --git a/src/backend/common.mk b/src/backend/common.mk
@@ -1,7 +1,7 @@
 #
 # Common make rules for backend
 #
-# $PostgreSQL: pgsql/src/backend/common.mk,v 1.2 2008/02/25 17:55:42 petere Exp $
+# $PostgreSQL: pgsql/src/backend/common.mk,v 1.3 2008/02/26 07:20:38 petere Exp $
 #
 
 # When including this file, set OBJS to the object files created in
@@ -26,9 +26,12 @@ endif
 SUBSYS.o: $(SUBDIROBJS) $(OBJS)
 	$(LD) $(LDREL) $(LDOUT) $@ $^
 
-objfiles.txt: $(SUBDIROBJS) $(OBJS)
+objfiles.txt:: $(MAKEFILE_LIST)
 	( $(if $(SUBDIROBJS),cat $(SUBDIROBJS); )echo $(addprefix $(subdir)/,$(OBJS)) ) >$@
 
+objfiles.txt:: $(SUBDIROBJS) $(OBJS)
+	touch $@
+
 # make function to expand objfiles.txt contents
 expand_subsys = $(foreach file,$(filter %/objfiles.txt,$(1)),$(patsubst ../../src/backend/%,%,$(addprefix $(top_builddir)/,$(shell cat $(file))))) $(filter-out %/objfiles.txt,$(1))
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`#`
`2`	`2`	`# Common make rules for backend`
`3`	`3`	`#`
`4`		`-# $PostgreSQL: pgsql/src/backend/common.mk,v 1.2 2008/02/25 17:55:42 petere Exp $`
	`4`	`+# $PostgreSQL: pgsql/src/backend/common.mk,v 1.3 2008/02/26 07:20:38 petere Exp $`
`5`	`5`	`#`
`6`	`6`
`7`	`7`	`# When including this file, set OBJS to the object files created in`
`@@ -26,9 +26,12 @@ endif`
`26`	`26`	`SUBSYS.o: $(SUBDIROBJS) $(OBJS)`
`27`	`27`	`$(LD) $(LDREL) $(LDOUT) $@ $^`
`28`	`28`
`29`		`-objfiles.txt: $(SUBDIROBJS) $(OBJS)`
	`29`	`+objfiles.txt:: $(MAKEFILE_LIST)`
`30`	`30`	`( $(if $(SUBDIROBJS),cat $(SUBDIROBJS); )echo $(addprefix $(subdir)/,$(OBJS)) ) >$@`
`31`	`31`
	`32`	`+objfiles.txt:: $(SUBDIROBJS) $(OBJS)`
	`33`	`+ touch $@`
	`34`	`+`
`32`	`35`	`# make function to expand objfiles.txt contents`
`33`	`36`	`expand_subsys = $(foreach file,$(filter %/objfiles.txt,$(1)),$(patsubst ../../src/backend/%,%,$(addprefix $(top_builddir)/,$(shell cat $(file))))) $(filter-out %/objfiles.txt,$(1))`
`34`	`37`