Remove temporary Windows-specific debugging code; it seems the problem

tglsfdc · tglsfdc · commit 36e012e72711 · 2006-11-06T17:10:22.000Z
with fopen() not using FILE_SHARE_DELETE was indeed the bug we were after,
given lack of recent reports.
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.130 2006/10/04 00:29:57 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.131 2006/11/06 17:10:22 tgl Exp $
  *
  * NOTES:
  *
@@ -1278,20 +1278,6 @@ AllocateFile(const char *name, const char *mode)
 		errno = save_errno;
 	}
 
-	/*
-	 * TEMPORARY hack to log the Windows error code on fopen failures, in
-	 * hopes of diagnosing some hard-to-reproduce problems.
-	 */
-#ifdef WIN32
-	{
-		int			save_errno = errno;
-
-		elog(LOG, "Windows fopen(\"%s\",\"%s\") failed: code %lu, errno %d",
-			 name, mode, GetLastError(), save_errno);
-		errno = save_errno;
-	}
-#endif
-
 	return NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.130 2006/10/04 00:29:57 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.131 2006/11/06 17:10:22 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES:`
`13`	`13`	`*`
`@@ -1278,20 +1278,6 @@ AllocateFile(const char name, const char mode)`
`1278`	`1278`	`errno = save_errno;`
`1279`	`1279`	`}`
`1280`	`1280`
`1281`		`- /*`
`1282`		`- * TEMPORARY hack to log the Windows error code on fopen failures, in`
`1283`		`- * hopes of diagnosing some hard-to-reproduce problems.`
`1284`		`- */`
`1285`		`-#ifdef WIN32`
`1286`		`- {`
`1287`		`- int save_errno = errno;`
`1288`		`-`
`1289`		`- elog(LOG, "Windows fopen(\"%s\",\"%s\") failed: code %lu, errno %d",`
`1290`		`- name, mode, GetLastError(), save_errno);`
`1291`		`- errno = save_errno;`
`1292`		`- }`
`1293`		`-#endif`
`1294`		`-`
`1295`	`1281`	`return NULL;`
`1296`	`1282`	`}`
`1297`	`1283`