Tighten casting of function call pointers for threads.

bmomjian · bmomjian · commit 38eb18092c88 · 2003-09-03T22:34:08.000Z
diff --git a/src/template/linux b/src/template/linux
@@ -1,7 +1,7 @@
 CFLAGS=-O2
 
 SUPPORTS_THREADS=yes
-NEED_REENTRANT_FUNC_NAMES=yes
+NEED_REENTRANT_FUNC_NAMES=yes	# verified glibc 2.1 2003-09-03
 THREAD_CFLAGS="-D_REENTRANT -D_THREAD_SAFE -D_POSIX_PTHREAD_SEMANTICS"
 THREAD_LIBS="-lpthread"
 
diff --git a/src/tools/test_thread_funcs.c b/src/tools/test_thread_funcs.c
@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- *	$Header: /cvsroot/pgsql/src/tools/Attic/test_thread_funcs.c,v 1.2 2003/09/03 19:36:31 momjian Exp $
+ *	$Header: /cvsroot/pgsql/src/tools/Attic/test_thread_funcs.c,v 1.3 2003/09/03 22:34:08 momjian Exp $
  *
  *	This program tests to see if your standard libc functions use
  *	pthread_setspecific()/pthread_getspecific() to be thread-safe.
@@ -57,8 +57,8 @@ int main(int argc, char *argv[])
 			return 1;
 	}
 
-	pthread_create(&thread1, NULL, (void *) func_call_1, NULL);
-	pthread_create(&thread2, NULL, (void *) func_call_2, NULL);
+	pthread_create(&thread1, NULL, (void * (*)(void *)) func_call_1, NULL);
+	pthread_create(&thread2, NULL, (void * (*)(void *)) func_call_2, NULL);
 	pthread_join(thread1, NULL);
 	pthread_join(thread2, NULL);
 

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`		`- * $Header: /cvsroot/pgsql/src/tools/Attic/test_thread_funcs.c,v 1.2 2003/09/03 19:36:31 momjian Exp $`
	`9`	`+ * $Header: /cvsroot/pgsql/src/tools/Attic/test_thread_funcs.c,v 1.3 2003/09/03 22:34:08 momjian Exp $`
`10`	`10`	`*`
`11`	`11`	`* This program tests to see if your standard libc functions use`
`12`	`12`	`* pthread_setspecific()/pthread_getspecific() to be thread-safe.`
`@@ -57,8 +57,8 @@ int main(int argc, char *argv[])`
`57`	`57`	`return 1;`
`58`	`58`	`}`
`59`	`59`
`60`		`- pthread_create(&thread1, NULL, (void *) func_call_1, NULL);`
`61`		`- pthread_create(&thread2, NULL, (void *) func_call_2, NULL);`
	`60`	`+ pthread_create(&thread1, NULL, (void * ()(void )) func_call_1, NULL);`
	`61`	`+ pthread_create(&thread2, NULL, (void * ()(void )) func_call_2, NULL);`
`62`	`62`	`pthread_join(thread1, NULL);`
`63`	`63`	`pthread_join(thread2, NULL);`
`64`	`64`