Add comment on C locale test for upper/lower/initcap().

bmomjian · bmomjian · commit 3adba41a3c31 · 2005-05-07T15:18:17.000Z
diff --git a/src/backend/utils/adt/oracle_compat.c b/src/backend/utils/adt/oracle_compat.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	$PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.59 2005/03/16 01:49:10 momjian Exp $
+ *	$PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.60 2005/05/07 15:18:17 momjian Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -167,7 +167,11 @@ Datum
 lower(PG_FUNCTION_ARGS)
 {
 #ifdef USE_WIDE_UPPER_LOWER
-	/* use wide char code only when max encoding length > 1 and ctype != C */
+	/*
+	 *	Use wide char code only when max encoding length > 1 and ctype != C.
+	 *	Some operating systems fail with multi-byte encodings and a C locale.
+	 *	Also, for a C locale there is no need to process as multibyte.
+	 */
 	if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())
 	{
 		text	   *string = PG_GETARG_TEXT_P(0);
@@ -229,7 +233,11 @@ Datum
 upper(PG_FUNCTION_ARGS)
 {
 #ifdef USE_WIDE_UPPER_LOWER
-	/* use wide char code only when max encoding length > 1 and ctype != C */
+	/*
+	 *	Use wide char code only when max encoding length > 1 and ctype != C.
+	 *	Some operating systems fail with multi-byte encodings and a C locale.
+	 *	Also, for a C locale there is no need to process as multibyte.
+	 */
 	if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())
 	{
 		text	   *string = PG_GETARG_TEXT_P(0);
@@ -294,7 +302,11 @@ Datum
 initcap(PG_FUNCTION_ARGS)
 {
 #ifdef USE_WIDE_UPPER_LOWER
-	/* use wide char code only when max encoding length > 1 and ctype != C */
+	/*
+	 *	Use wide char code only when max encoding length > 1 and ctype != C.
+	 *	Some operating systems fail with multi-byte encodings and a C locale.
+	 *	Also, for a C locale there is no need to process as multibyte.
+	 */
 	if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())
 	{
 		text	   *string = PG_GETARG_TEXT_P(0);

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`*`
`10`	`10`	`*`
`11`	`11`	`* IDENTIFICATION`
`12`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.59 2005/03/16 01:49:10 momjian Exp $`
	`12`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/oracle_compat.c,v 1.60 2005/05/07 15:18:17 momjian Exp $`
`13`	`13`	`*`
`14`	`14`	`*-------------------------------------------------------------------------`
`15`	`15`	`*/`
`@@ -167,7 +167,11 @@ Datum`
`167`	`167`	`lower(PG_FUNCTION_ARGS)`
`168`	`168`	`{`
`169`	`169`	`#ifdef USE_WIDE_UPPER_LOWER`
`170`		`- /* use wide char code only when max encoding length > 1 and ctype != C */`
	`170`	`+ /*`
	`171`	`+ * Use wide char code only when max encoding length > 1 and ctype != C.`
	`172`	`+ * Some operating systems fail with multi-byte encodings and a C locale.`
	`173`	`+ * Also, for a C locale there is no need to process as multibyte.`
	`174`	`+ */`
`171`	`175`	`if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())`
`172`	`176`	`{`
`173`	`177`	`text *string = PG_GETARG_TEXT_P(0);`
`@@ -229,7 +233,11 @@ Datum`
`229`	`233`	`upper(PG_FUNCTION_ARGS)`
`230`	`234`	`{`
`231`	`235`	`#ifdef USE_WIDE_UPPER_LOWER`
`232`		`- /* use wide char code only when max encoding length > 1 and ctype != C */`
	`236`	`+ /*`
	`237`	`+ * Use wide char code only when max encoding length > 1 and ctype != C.`
	`238`	`+ * Some operating systems fail with multi-byte encodings and a C locale.`
	`239`	`+ * Also, for a C locale there is no need to process as multibyte.`
	`240`	`+ */`
`233`	`241`	`if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())`
`234`	`242`	`{`
`235`	`243`	`text *string = PG_GETARG_TEXT_P(0);`
`@@ -294,7 +302,11 @@ Datum`
`294`	`302`	`initcap(PG_FUNCTION_ARGS)`
`295`	`303`	`{`
`296`	`304`	`#ifdef USE_WIDE_UPPER_LOWER`
`297`		`- /* use wide char code only when max encoding length > 1 and ctype != C */`
	`305`	`+ /*`
	`306`	`+ * Use wide char code only when max encoding length > 1 and ctype != C.`
	`307`	`+ * Some operating systems fail with multi-byte encodings and a C locale.`
	`308`	`+ * Also, for a C locale there is no need to process as multibyte.`
	`309`	`+ */`
`298`	`310`	`if (pg_database_encoding_max_length() > 1 && !lc_ctype_is_c())`
`299`	`311`	`{`
`300`	`312`	`text *string = PG_GETARG_TEXT_P(0);`