Fix error status of vacuumdb when multiple jobs are used

michaelpq · michaelpq · commit 3ae3c18b3628 · 2019-05-09T10:29:10.000+09:00
When running a batch of VACUUM or ANALYZE commands on a given database, there were cases where it is possible to have vacuumdb not report an error where it actually should, leading to incorrect status results. Author: Julien Rouhaud Reviewed-by: Amit Kapila, Michael Paquier Discussion: https://postgr.es/m/CAOBaU_ZuTwz7CtqLYJ1Ouuh272bTQPLN8b1bAPk0bCBm4PDMTQ@mail.gmail.com Backpatch-through: 9.5
diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
@@ -712,7 +712,10 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
 		for (j = 0; j < concurrentCons; j++)
 		{
 			if (!GetQueryResult((slots + j)->connection, progname))
+			{
+				failed = true;
 				goto finish;
+			}
 		}
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -712,7 +712,10 @@ vacuum_one_database(const char dbname, vacuumingOptions vacopts,`
`712`	`712`	`for (j = 0; j < concurrentCons; j++)`
`713`	`713`	`{`
`714`	`714`	`if (!GetQueryResult((slots + j)->connection, progname))`
	`715`	`+ {`
	`716`	`+ failed = true;`
`715`	`717`	`goto finish;`
	`718`	`+ }`
`716`	`719`	`}`
`717`	`720`	`}`
`718`	`721`