CI scripts: document run_install_check and make make_test_base report error corretly

vbwagner · vbwagner · commit 3b54027c99aa · 2017-01-24T15:03:14.000+03:00
diff --git a/.ci/make_test_base b/.ci/make_test_base
@@ -9,12 +9,12 @@ On success, starts database
 """
 import os,sys,subprocess,glob,re,os.path,time
 
-datadir=sys.argv[1]
-
-if not datadir:
-    print >>sys.stderr,"Usage %s directory"%sys.argv[0]
+if len(sys.argv)!=2:
+    print >>sys.stderr,"Usage %s data-directory" % sys.argv[0]
     sys.exit(1)
 
+datadir=sys.argv[1]
+
 if os.access(datadir,os.R_OK):
     import shutil
     shutil.rmtree(datadir)
diff --git a/.ci/run_install_check b/.ci/run_install_check
@@ -2,6 +2,19 @@
 # Makes temporary installation and runs installcheck-world on it
 # Should be run as non-privileged user.
 # Exit on all errors
+# If run without arguments, makes installcheck-world
+# Otherwise first argument is interpreted as subdirectory 
+# to change before runnning make installchedk
+# i.e
+#    run_install_check . 
+# test core only
+#    run_install_check contrib
+# tests contrib only
+# etc.
+# All other arguments are passed to Makefile intact
+# To make possible pass arguments to installcheck-world
+#    run_install_check world
+# does the same as no args
 set -e
 # Install
 make install prefix=`pwd`/tmp_install
@@ -19,7 +32,7 @@ export PGPORT
 ./.ci/make_test_base $PGDATA
 #run checks
 set +e
-if [  -z "$1" ]; then
+if [  -z "$1" -o "$1" = "world" ]; then
 make installcheck-world  prefix=`pwd`/tmp_install NO_LOCALE=1
 else
 dir=$1
