Just noticed that with -S switch, MyProcPid is permanently wrong in

tglsfdc · tglsfdc · commit 3c0f3c9a7e56 · 2000-11-29T22:04:04.000Z
postmaster, because it isn't updated after forking away from the terminal.
Apparently it's not used anyplace in the postmaster ... but seems best
to make it show the correct PID ...
diff --git a/src/backend/postmaster/postmaster.c b/src/backend/postmaster/postmaster.c
@@ -11,7 +11,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.195 2000/11/29 20:59:52 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.196 2000/11/29 22:04:04 tgl Exp $
  *
  * NOTES
  *
@@ -679,7 +679,7 @@ pmdaemonize(int argc, char *argv[])
 	pid_t		pid;
 
 	pid = fork();
-	if (pid == -1)
+	if (pid == (pid_t) -1)
 	{
 		perror("Failed to fork postmaster");
 		ExitPostmaster(1);
@@ -691,6 +691,8 @@ pmdaemonize(int argc, char *argv[])
 		_exit(0);
 	}
 
+	MyProcPid = getpid();		/* reset MyProcPid to child */
+
 /* GH: If there's no setsid(), we hopefully don't need silent mode.
  * Until there's a better solution.
  */

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`	`*`
`12`	`12`	`*`
`13`	`13`	`* IDENTIFICATION`
`14`		`- * $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.195 2000/11/29 20:59:52 tgl Exp $`
	`14`	`+ * $Header: /cvsroot/pgsql/src/backend/postmaster/postmaster.c,v 1.196 2000/11/29 22:04:04 tgl Exp $`
`15`	`15`	`*`
`16`	`16`	`* NOTES`
`17`	`17`	`*`
`@@ -679,7 +679,7 @@ pmdaemonize(int argc, char *argv[])`
`679`	`679`	`pid_t pid;`
`680`	`680`
`681`	`681`	`pid = fork();`
`682`		`- if (pid == -1)`
	`682`	`+ if (pid == (pid_t) -1)`
`683`	`683`	`{`
`684`	`684`	`perror("Failed to fork postmaster");`
`685`	`685`	`ExitPostmaster(1);`
`@@ -691,6 +691,8 @@ pmdaemonize(int argc, char *argv[])`
`691`	`691`	`_exit(0);`
`692`	`692`	`}`
`693`	`693`
	`694`	`+ MyProcPid = getpid(); /* reset MyProcPid to child */`
	`695`	`+`
`694`	`696`	`/* GH: If there's no setsid(), we hopefully don't need silent mode.`
`695`	`697`	`* Until there's a better solution.`
`696`	`698`	`*/`