Initialize new jsonb iterator to zero

petere · petere · commit 3c9cf069454d · 2018-05-28T23:53:43.000-04:00
Use palloc0() instead of palloc() to create a new JsonbIterator.
Otherwise, the isScalar field is sometimes not initialized.  There is
probably no impact in practice, but it's cleaner this way and it avoids
future problems.
diff --git a/src/backend/utils/adt/jsonb_util.c b/src/backend/utils/adt/jsonb_util.c
@@ -901,7 +901,7 @@ iteratorFromContainer(JsonbContainer *container, JsonbIterator *parent)
 {
 	JsonbIterator *it;
 
-	it = palloc(sizeof(JsonbIterator));
+	it = palloc0(sizeof(JsonbIterator));
 	it->container = container;
 	it->parent = parent;
 	it->nElems = JsonContainerSize(container);

Original file line number	Diff line number	Diff line change
`@@ -901,7 +901,7 @@ iteratorFromContainer(JsonbContainer container, JsonbIterator parent)`
`901`	`901`	`{`
`902`	`902`	`JsonbIterator *it;`
`903`	`903`
`904`		`- it = palloc(sizeof(JsonbIterator));`
	`904`	`+ it = palloc0(sizeof(JsonbIterator));`
`905`	`905`	`it->container = container;`
`906`	`906`	`it->parent = parent;`
`907`	`907`	`it->nElems = JsonContainerSize(container);`