Fix unhandled xact_event in postgres_fdw

kelvich · kelvich · commit 3f3082c03f76 · 2017-02-02T21:15:41.000+03:00
diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c
@@ -593,6 +593,20 @@ pgfdw_xact_callback(XactEvent event, void *arg)
 	HASH_SEQ_STATUS scan;
 	ConnCacheEntry *entry;
 
+	/* Do nothing for this events */
+	switch (event)
+	{
+		case XACT_EVENT_START:
+		case XACT_EVENT_POST_PREPARE:
+		case XACT_EVENT_COMMIT_PREPARED:
+		case XACT_EVENT_PRE_COMMIT_PREPARED:
+		case XACT_EVENT_ABORT_PREPARED:
+		case XACT_EVENT_COMMIT_COMMAND:
+			return;
+		default:
+			break;
+	}
+
 	/* Quick exit if no connections were touched in this transaction. */
 	if (!xact_got_connection)
 		return;
@@ -714,6 +728,18 @@ pgfdw_xact_callback(XactEvent event, void *arg)
 						entry->have_error = false;
 					}
 					break;
+				case XACT_EVENT_START:
+				case XACT_EVENT_POST_PREPARE:
+				case XACT_EVENT_COMMIT_PREPARED:
+				case XACT_EVENT_PRE_COMMIT_PREPARED:
+				case XACT_EVENT_ABORT_PREPARED:
+				case XACT_EVENT_COMMIT_COMMAND:
+					/*
+					 * New event can break our state machine, so let's list
+					 * them here explicitely and force compiler warning in
+					 * case of unhandled event.
+					 */
+					break;
 			}
 		}
 
