Fix direct access to Relation->rd_indpred.

tglsfdc · tglsfdc · commit 405a468b02dd · 2013-07-18T01:02:18.000-04:00
Should use RelationGetIndexPredicate(), since rd_indpred is just a cache
that is not computed until/unless demanded.  Per buildfarm failure on
CLOBBER_CACHE_ALWAYS animals; diagnosis and fix by Hitoshi Harada.
diff --git a/src/backend/commands/matview.c b/src/backend/commands/matview.c
@@ -634,7 +634,7 @@ refresh_by_match_merge(Oid matviewOid, Oid tempOid)
 
 			/* Skip partial indexes. */
 			indexRel = index_open(index->indexrelid, RowExclusiveLock);
-			if (indexRel->rd_indpred != NIL)
+			if (RelationGetIndexPredicate(indexRel) != NIL)
 			{
 				index_close(indexRel, NoLock);
 				ReleaseSysCache(indexTuple);

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ refresh_by_match_merge(Oid matviewOid, Oid tempOid)`
`634`	`634`
`635`	`635`	`/* Skip partial indexes. */`
`636`	`636`	`indexRel = index_open(index->indexrelid, RowExclusiveLock);`
`637`		`- if (indexRel->rd_indpred != NIL)`
	`637`	`+ if (RelationGetIndexPredicate(indexRel) != NIL)`
`638`	`638`	`{`
`639`	`639`	`index_close(indexRel, NoLock);`
`640`	`640`	`ReleaseSysCache(indexTuple);`