Add config sanity check in mmts.

kvap · kelvich · commit 44e3d9d76049 · 2017-11-13T02:17:31.000+03:00
diff --git a/multimaster.c b/multimaster.c
@@ -1935,6 +1935,68 @@ static void MtmSplitConnStrs(void)
 	pfree(copy);
 }		
 
+static bool ConfigIsSane(void)
+{
+	bool ok = true;
+
+	if (DefaultXactIsoLevel != XACT_REPEATABLE_READ)
+	{
+		elog(WARNING, "multimaster requires default_transaction_isolation = 'repeatable read'");
+		ok = false;
+	}
+
+	if (MtmMaxNodes < 1)
+	{
+		elog(WARNING, "multimaster requires multimaster.max_nodes > 0");
+		ok = false;
+	}
+
+	if (max_prepared_xacts < 1)
+	{
+		elog(WARNING,
+			 "multimaster requires max_prepared_transactions > 0, "
+			 "because all transactions are implicitly two-phase");
+		ok = false;
+	}
+
+	{
+		int workers_required = 2 * MtmMaxNodes + MtmWorkers + 1;
+		if (max_worker_processes < workers_required)
+		{
+			elog(WARNING,
+				 "multimaster requires max_worker_processes >= %d",
+				 workers_required);
+			ok = false;
+		}
+	}
+
+	if (wal_level != WAL_LEVEL_LOGICAL)
+	{
+		elog(WARNING,
+			 "multimaster requires wal_level = 'logical', "
+			 "because it is build on top of logical replication");
+		ok = false;
+	}
+
+	if (max_wal_senders < MtmMaxNodes)
+	{
+		elog(WARNING,
+			 "multimaster requires max_wal_senders >= %d (multimaster.max_nodes), ",
+			 MtmMaxNodes);
+		ok = false;
+	}
+
+	if (max_replication_slots < MtmMaxNodes)
+	{
+		elog(WARNING,
+			 "multimaster requires max_replication_slots >= %d (multimaster.max_nodes), ",
+			 MtmMaxNodes);
+		ok = false;
+	}
+
+	return ok;
+}
+
 void
 _PG_init(void)
 {
@@ -2274,18 +2336,15 @@ _PG_init(void)
 		NULL
 	);
 
-	if (DefaultXactIsoLevel != XACT_REPEATABLE_READ) { 
-		elog(ERROR, "Multimaster requires repeatable read default isolation level");
-	}
-#if 0
-	if (synchronous_commit != SYNCHRONOUS_COMMIT_ON) { 
-		elog(ERROR, "Multimaster requires synchronous commit on");
+	if (!ConfigIsSane()) {
+		elog(ERROR, "Multimaster config is insane, refusing to work");
 	}
-#endif
 
+	/* This will also perform some checks on connection strings */
 	MtmSplitConnStrs();
+
     MtmStartReceivers();
-		
+
 	/*
 	 * Request additional shared resources.  (These are no-ops if we're not in
 	 * the postmaster process.)  We'll allocate or attach to the shared
diff --git a/tests/daemons.go b/tests/daemons.go
@@ -112,12 +112,13 @@ func postgres(bin string, datadir string, postgresi []string, port int, nodeid i
 		"-c", "max_connections=200",
 		"-c", "max_replication_slots=10",
 		"-c", "max_wal_senders=10",
-		"-c", "max_worker_processes=100",
-		"-c", "max_prepared_transactions=200",
+		"-c", "max_worker_processes=11",
+		"-c", "max_prepared_transactions=10",
 		"-c", "default_transaction_isolation=repeatable read",
 		"-c", "multimaster.conn_strings=" + strings.Join(postgresi, ","),
 		"-c", "multimaster.node_id=" + strconv.Itoa(nodeid + 1),
 		"-c", "multimaster.queue_size=52857600",
+		"-c", "multimaster.max_nodes=3",
 		"-c", "multimaster.workers=4",
 		"-c", "multimaster.use_raftable=true",
 		"-c", "multimaster.ignore_tables_without_pk=1",
